fix(log-messages): reduce excessive log messages

[ahmeddesokyebrahim]

Description

This PR is one of group of PRs that aim to fix Autoware logging system to achieve the goal of reducing excessive error and warning logs on Autoware launch.

Fixes autowarefoundation/autoware.universe#5539

Related links

More details in the issue.

Relevant PRS

• autoware.universe
• autoware_launch
• tier4/pointcloud_to_laserscan

Tests performed

• Planning Simulation
  • Run Autoware planning simulator and you can see no more excessive and recurring error, warning, and info message when the system running as expected
• Rosbag Replay Simulation
  • To be addressed in another PR
• AWSIM
  • To be addressed in another PR - extended goal

Notes for reviewers

Take into consideration relevant PRs.

Interface changes

N.A

Effects on system behavior

• Improved console output => better developer experience specially for debugging and catching actual problems.
• Some recurrent info messages are lowered to debug level. So the developer would need to set the logger level of that specific node to see the debug message.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.
• The PR has been properly tested.
• The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.
• The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (d3ff59a) 9.71% compared to head (3515fb0) 9.66%.

Files	Patch %	Lines
tmp/lanelet2_extension/lib/visualization.cpp	0.00%	17 Missing ⚠️
tmp/lanelet2_extension/lib/query.cpp	0.00%	11 Missing ⚠️
tmp/lanelet2_extension_python/src/utility.cpp	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##            main    #224      +/-   ##
========================================
- Coverage   9.71%   9.66%   -0.06%     
========================================
  Files         40      40              
  Lines       3097    3115      +18     
  Branches    1387    1399      +12     
========================================
  Hits         301     301              
- Misses      2376    2394      +18     
  Partials     420     420              

Flag	Coverage Δ		*Carryforward flag
differential	8.14% <0.00%> (?)
total	9.75% <ø> (+0.03%)	⬆️	Carriedforward from e9b18cb

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[xmfcx]

With this PR, visualization::pedestrianMarkingsAsMarkerArray is separated into:

• visualization::pedestrianPolygonMarkingsAsMarkerArray
• visualization::pedestrianLineMarkingsAsMarkerArray

I've checked the codebase and all the usages of pedestrianMarkingsAsMarkerArray are updated with the trailing PRs.

To avoid warnings and be able to visualize lines along with polygons too.

This is before this change:

This is after this change:

Pay attention to marked areas:

[xmfcx]

@kosuke55
@soblin
@Motsu-san
@mitsudome-r
@takayuki5168

If you don't have any concerns, I will merge this along with the other 2 PRs:

• fix(log-messages): reduce excessive log messages autoware.universe#5971
• fix(log-messages): reduce excessive log messages autoware_launch#760