Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(object_lanelet_filter): add configurable margin for object lanel… #1210

Conversation

sebekx
Copy link
Contributor

@sebekx sebekx commented Nov 5, 2024

Description
Necessary changes for: pr

Copy link
Contributor

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin
Copy link
Contributor

@YoshiRi Can you confirm this with PR autowarefoundation/autoware.universe#9240?

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin self-assigned this Nov 28, 2024
@sebekx sebekx force-pushed the feat/autoware_detected_object_validation branch from af3ef96 to de728c9 Compare November 28, 2024 07:05
@sebekx sebekx force-pushed the feat/autoware_detected_object_validation branch from de728c9 to a14aa9b Compare November 29, 2024 09:45
@technolojin technolojin merged commit 3cd81cc into autowarefoundation:main Dec 2, 2024
13 checks passed
yuki-takagi-66 added a commit to tier4/autoware_launch that referenced this pull request Dec 3, 2024
* refactor(system_diagnostic_monitor, dummy_diag_publisher, diagnostic_graph_aggregator): combine diag list setting directories (autowarefoundation#1253)

Signed-off-by: yuki-takagi-66 <[email protected]>

* feat(object_lanelet_filter): add configurable margin for object lanel… (autowarefoundation#1210)

feat(object_lanelet_filter): add configurable margin for object lanelet filter

Signed-off-by: Sebastian Zęderowski <[email protected]>
Co-authored-by: Sebastian Zęderowski <[email protected]>

* fix(rviz): fix a bug about visualizing ego model (autowarefoundation#1257)

fix a visulization bug.

Signed-off-by: temkei.kem <[email protected]>

---------

Signed-off-by: yuki-takagi-66 <[email protected]>
Signed-off-by: Sebastian Zęderowski <[email protected]>
Signed-off-by: temkei.kem <[email protected]>
Co-authored-by: Yuki TAKAGI <[email protected]>
Co-authored-by: Sebastian Zęderowski <[email protected]>
Co-authored-by: Sebastian Zęderowski <[email protected]>
Co-authored-by: Kem (TiankuiXian) <[email protected]>
yuki-takagi-66 added a commit to tier4/autoware_launch that referenced this pull request Dec 5, 2024
* refactor(system_diagnostic_monitor, dummy_diag_publisher, diagnostic_graph_aggregator): combine diag list setting directories (autowarefoundation#1253)

Signed-off-by: yuki-takagi-66 <[email protected]>

* feat(object_lanelet_filter): add configurable margin for object lanel… (autowarefoundation#1210)

feat(object_lanelet_filter): add configurable margin for object lanelet filter

Signed-off-by: Sebastian Zęderowski <[email protected]>
Co-authored-by: Sebastian Zęderowski <[email protected]>

* fix(rviz): fix a bug about visualizing ego model (autowarefoundation#1257)

fix a visulization bug.

Signed-off-by: temkei.kem <[email protected]>

* refactor(glog_component): prefix package and namespace with autoware (autowarefoundation#1245)

Signed-off-by: Esteve Fernandez <[email protected]>

* refactor(global_parameter_loader): prefix package and namespace with autoware (autowarefoundation#1246)

Signed-off-by: Esteve Fernandez <[email protected]>

* feat(lane_change): add new lane change parameter (autowarefoundation#1224)

* add minimum prepare duration parameter

Signed-off-by: mohammad alqudah <[email protected]>

* increase min_prepare_duration to 1.0 s

Signed-off-by: mohammad alqudah <[email protected]>

* increase min prepare duration value, add new parameter

Signed-off-by: mohammad alqudah <[email protected]>

---------

Signed-off-by: mohammad alqudah <[email protected]>

---------

Signed-off-by: yuki-takagi-66 <[email protected]>
Signed-off-by: Sebastian Zęderowski <[email protected]>
Signed-off-by: temkei.kem <[email protected]>
Signed-off-by: Esteve Fernandez <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
Co-authored-by: Yuki TAKAGI <[email protected]>
Co-authored-by: Sebastian Zęderowski <[email protected]>
Co-authored-by: Sebastian Zęderowski <[email protected]>
Co-authored-by: Kem (TiankuiXian) <[email protected]>
Co-authored-by: Esteve Fernandez <[email protected]>
Co-authored-by: mkquda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants