Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(processing_time_checker): update processing time list #1236

Conversation

Kazunori-Nakajima
Copy link
Contributor

@Kazunori-Nakajima Kazunori-Nakajima commented Nov 18, 2024

Description

Purpose

To be able to check the values of the modules added in the relationship PR in the scenario.

Merit

To be able to measure module processing time periodically by scenario.And leads to the following
-> Prevention of cycle failures.
-> Suggestion to improve module processing speed.

Updated

Added 5 module paths to processing_time_checker.yml to read processing_time_pub from the scenario.

Related links

Tests performed

image

Notes for reviewers

Interface changes

This PR

  • processing_time_checker

Related PR (universe)

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

  • I've confirmed the [contribution guidelines].
  • The PR follows the [pull request guidelines].

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the [pull request guidelines].
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.
[contribution guidelines]: https://autowarefoundation.github.io/autoware-documentation/main/contributing/
[pull request guidelines]: https://autowarefoundation.github.io/autoware-documentation/main/contributing/pull-request-guidelines/

Copy link
Contributor

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ito-san
Copy link
Contributor

ito-san commented Nov 19, 2024

Made a slight correction in the 'Related PR' section.

@ito-san ito-san assigned ito-san and Kazunori-Nakajima and unassigned ito-san Nov 19, 2024
@kosuke55 kosuke55 merged commit ea30ec0 into autowarefoundation:main Nov 20, 2024
31 checks passed
@Kazunori-Nakajima Kazunori-Nakajima deleted the update_processing_time_list branch January 20, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants