Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ndt_scan_matcher): match ndt_scan_matcher.param.yaml #583

Conversation

TaikiYamada4
Copy link
Contributor

@TaikiYamada4 TaikiYamada4 commented Sep 22, 2023

Description

Fixed ndt_scan_matcher.param.yaml to match to the one in universe, where autoware_launch misses ndt_base_frame and has an unneeded neighborhood_search_method.

Tests performed

Successfully built, autoware_launch, and rosbag replay simulation in the tutorial has been tested in my environment too.

Effects on system behavior

This shouldn't affect the system behavior.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@TaikiYamada4 TaikiYamada4 marked this pull request as ready for review September 22, 2023 07:04
@TaikiYamada4 TaikiYamada4 merged commit 484b7ea into autowarefoundation:main Sep 22, 2023
8 of 9 checks passed
@TaikiYamada4 TaikiYamada4 deleted the refactor/ndt_scan_matcher_param_yaml branch September 22, 2023 07:07
TomohitoAndo pushed a commit to TomohitoAndo/autoware_launch.awf that referenced this pull request Oct 20, 2023
…on#583)

* feat(planning_launch): lane change abort parameters

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* allow very high lateral jerk for now

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* remove unnecessary parameter

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* set abort to false

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* fix parameter

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
* fix(rviz): fix topic name of traffic_light

Signed-off-by: 1222-takeshi <[email protected]>

* feat: update multi_data_monitor yaml for traffic_light

Signed-off-by: 1222-takeshi <[email protected]>

---------

Signed-off-by: 1222-takeshi <[email protected]>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Feb 6, 2024
* fix(rviz): fix topic name of traffic_light

Signed-off-by: 1222-takeshi <[email protected]>

* feat: update multi_data_monitor yaml for traffic_light

Signed-off-by: 1222-takeshi <[email protected]>

---------

Signed-off-by: 1222-takeshi <[email protected]>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 21, 2024
…ion for approval (autowarefoundation#881) (autowarefoundation#583)

feat(strat_planner): add a prepare time for blinker before taking action for approval (autowarefoundation#881)

Signed-off-by: Mamoru Sobue <[email protected]>
Kazunori-Nakajima pushed a commit to Kazunori-Nakajima/autoware_launch that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants