Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pid_longitudinal_controller): adjust slope compensation parameters #585

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

brkay54
Copy link
Member

@brkay54 brkay54 commented Sep 22, 2023

Description

Because the slope compensation algorithm changes, we need to adjust parameters.
autowarefoundation/autoware.universe#4712

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@brkay54 brkay54 self-assigned this Sep 30, 2023
TomohitoAndo pushed a commit to TomohitoAndo/autoware_launch.awf that referenced this pull request Oct 20, 2023
@brkay54 brkay54 force-pushed the pid/remove-slope-option branch from 122ec66 to fdcd584 Compare November 10, 2023 12:44
@brkay54 brkay54 changed the title feat(pid_longitudinal_controller): remove use_trajectory_for_pitch_calculation option feat(pid_longitudinal_controller): adjust slope compensation parameters Nov 10, 2023
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
@brkay54 brkay54 force-pushed the pid/remove-slope-option branch from fdcd584 to 84bfb8f Compare December 5, 2023 12:38
@brkay54 brkay54 force-pushed the pid/remove-slope-option branch from 84bfb8f to 81fe47e Compare December 21, 2023 07:03
@brkay54 brkay54 force-pushed the pid/remove-slope-option branch 2 times, most recently from 8d2b58e to a5b5967 Compare February 1, 2024 10:26
@brkay54 brkay54 force-pushed the pid/remove-slope-option branch from a5b5967 to 7f148c7 Compare February 5, 2024 22:29
@brkay54 brkay54 requested a review from TakaHoribe February 5, 2024 22:32
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brkay54 brkay54 merged commit 4afc06f into autowarefoundation:main Feb 9, 2024
10 of 11 checks passed
yuki-takagi-66 referenced this pull request in tier4/autoware_launch Jul 8, 2024
* chore: change max_z of cropbox filter to vehicle_height

Signed-off-by: badai-nguyen <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: badai-nguyen <[email protected]>
Co-authored-by: badai-nguyen <[email protected]>
Kazunori-Nakajima pushed a commit to Kazunori-Nakajima/autoware_launch that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants