Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avoidance): return original lane by red traffic light #663

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Oct 28, 2023

Description

See autowarefoundation/autoware.universe#5395.

Tests performed

Evaluator.

Effects on system behavior

Improve avoidance behavior.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@satoshi-ota satoshi-ota force-pushed the feat/use-traffic-light-in-avoidance branch from 9791fec to 48e0cf0 Compare October 28, 2023 08:28
@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c8fb4e) 0.00% compared to head (48e0cf0) 0.00%.

❗ Current head 48e0cf0 differs from pull request most recent head 1185b8d. Consider uploading reports for the commit 1185b8d to get more accurate results

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #663   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota force-pushed the feat/use-traffic-light-in-avoidance branch from 48e0cf0 to 1185b8d Compare October 30, 2023 01:33
@satoshi-ota satoshi-ota marked this pull request as ready for review October 30, 2023 01:33
@kyoichi-sugahara kyoichi-sugahara self-assigned this Oct 30, 2023
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@satoshi-ota satoshi-ota merged commit 0debb71 into main Oct 31, 2023
9 of 10 checks passed
@satoshi-ota satoshi-ota deleted the feat/use-traffic-light-in-avoidance branch October 31, 2023 09:41
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
…ar_object_merger_params

chore: update radar object tracking merger params
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants