-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(avoidance): use traffic light signal info #5395
feat(avoidance): use traffic light signal info #5395
Conversation
d132ac0
to
e58e1f6
Compare
e58e1f6
to
1fb7ce9
Compare
Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
… signal into account Signed-off-by: satoshi-ota <[email protected]>
1fb7ce9
to
dbdf28c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5395 +/- ##
==========================================
- Coverage 14.75% 14.75% -0.01%
==========================================
Files 1662 1662
Lines 115741 115826 +85
Branches 35764 35818 +54
==========================================
+ Hits 17081 17091 +10
- Misses 79344 79394 +50
- Partials 19316 19341 +25
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* feat(utils): add function to calculate shift start/end point Signed-off-by: satoshi-ota <[email protected]> * feat(avoidance): add new parameter Signed-off-by: satoshi-ota <[email protected]> * feat(avoidance): set shift start/end point with module taking traffic signal into account Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
Description
Please review following PR at first:
autowarefoundation/autoware_launch#663
In this PR, avoidance module takes traffic light signal recognitino results into consideration so that it can make more natural path at intersection.
The module decides where the ego should return original lane or start avoidance maneuver from traffic light signal.
Tests performed
Test with TrafficLightPublishPanel.
Traffic light signal: GREEN
simplescreenrecorder-2023-10-25_08.51.00.mp4
Traffic light signal: RED
simplescreenrecorder-2023-10-25_08.51.37.mp4
Effects on system behavior
Improve avoidance behavior.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.