Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avoidance): use traffic light signal info #5395

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Oct 24, 2023

Description

Please review following PR at first:
autowarefoundation/autoware_launch#663

In this PR, avoidance module takes traffic light signal recognitino results into consideration so that it can make more natural path at intersection.

The module decides where the ego should return original lane or start avoidance maneuver from traffic light signal.

Traffic light color: GREEN Traffic light color: RED
Object is FARTHER than traffic light stop line. (current shift > 0) Screenshot from 2023-10-28 17-25-37 return point is sometimes behind the traffic light stop line. Screenshot from 2023-10-28 17-25-46 set return point in front of the traffic light stop line.
Object is NEARER than traffic light stop line. (current shift = 0.0) Screenshot from 2023-10-28 17-24-29 avoidance start point is sometimes in front of the traffic light stop line. Screenshot from 2023-10-28 17-24-16 set avoidance start point behind the traffic light stop line.

Tests performed

Test with TrafficLightPublishPanel.

Traffic light signal: GREEN

simplescreenrecorder-2023-10-25_08.51.00.mp4

Traffic light signal: RED

simplescreenrecorder-2023-10-25_08.51.37.mp4

Effects on system behavior

Improve avoidance behavior.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Oct 24, 2023
@satoshi-ota satoshi-ota force-pushed the feat/use-traffic-light-in-avoidance branch 2 times, most recently from d132ac0 to e58e1f6 Compare October 28, 2023 08:29
@satoshi-ota satoshi-ota force-pushed the feat/use-traffic-light-in-avoidance branch from e58e1f6 to 1fb7ce9 Compare October 28, 2023 08:36
@satoshi-ota satoshi-ota force-pushed the feat/use-traffic-light-in-avoidance branch from 1fb7ce9 to dbdf28c Compare October 30, 2023 01:32
@github-actions github-actions bot removed the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Oct 30, 2023
@satoshi-ota satoshi-ota marked this pull request as ready for review October 30, 2023 01:33
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 91 lines in your changes are missing coverage. Please review.

Comparison is base (02b2be9) 14.75% compared to head (dbdf28c) 14.75%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5395      +/-   ##
==========================================
- Coverage   14.75%   14.75%   -0.01%     
==========================================
  Files        1662     1662              
  Lines      115741   115826      +85     
  Branches    35764    35818      +54     
==========================================
+ Hits        17081    17091      +10     
- Misses      79344    79394      +50     
- Partials    19316    19341      +25     
Flag Coverage Δ *Carryforward flag
differential 12.20% <9.00%> (?)
total 14.76% <ø> (+<0.01%) ⬆️ Carriedforward from 02b2be9

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...anner/include/behavior_path_planner/parameters.hpp 57.14% <ø> (ø)
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...ner/include/behavior_path_planner/data_manager.hpp 34.78% <0.00%> (-15.22%) ⬇️
...ath_planner/src/scene_module/avoidance/manager.cpp 6.00% <0.00%> (-0.14%) ⬇️
...or_path_planner/src/behavior_path_planner_node.cpp 26.81% <0.00%> (-0.50%) ⬇️
...er/src/scene_module/avoidance/avoidance_module.cpp 12.16% <4.34%> (+0.06%) ⬆️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 11.63% <15.09%> (+0.23%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara kyoichi-sugahara self-assigned this Oct 30, 2023
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@satoshi-ota satoshi-ota merged commit 1998880 into autowarefoundation:main Oct 31, 2023
28 of 32 checks passed
@satoshi-ota satoshi-ota deleted the feat/use-traffic-light-in-avoidance branch October 31, 2023 09:41
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Nov 1, 2023
* feat(utils): add function to calculate shift start/end point

Signed-off-by: satoshi-ota <[email protected]>

* feat(avoidance): add new parameter

Signed-off-by: satoshi-ota <[email protected]>

* feat(avoidance): set shift start/end point with module taking traffic signal into account

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants