Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(multi_object_tracker): add multi_object_tracker node param #718

Merged

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Dec 4, 2023

Description

This PR is related with

Move multi_object_tracker node params to yaml file.

Tests performed

Tested with Lsim.

Effects on system behavior

Need to update each projects launcher.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshiRi YoshiRi enabled auto-merge (squash) December 5, 2023 05:37
@YoshiRi YoshiRi merged commit 6d6af42 into autowarefoundation:main Dec 5, 2023
9 of 10 checks passed
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Feb 6, 2024
mitukou1109 pushed a commit to mitukou1109/autoware_launch that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants