Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multi_object_tracker): fix typo in node parameters #735

Closed

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Dec 13, 2023

Description

Fix typo in tracker node parameters.
This typo may not affect autoware launch because tracker node has error escape when the parameter is not set.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@YoshiRi YoshiRi marked this pull request as ready for review December 13, 2023 05:29
@YoshiRi YoshiRi requested a review from yukkysaito December 21, 2023 01:49
sykwer pushed a commit to sykwer/autoware_launch that referenced this pull request Jan 3, 2024
…dation#735)

* feat(mpc_lateral_controller): add steering bias removal

Signed-off-by: Takamasa Horibe <[email protected]>

* change name

Signed-off-by: Takamasa Horibe <[email protected]>

Signed-off-by: Takamasa Horibe <[email protected]>
@YoshiRi
Copy link
Contributor Author

YoshiRi commented Jan 13, 2024

Thanks to @miursh this change is already merged in #785.

@YoshiRi YoshiRi closed this Jan 13, 2024
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Feb 6, 2024
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant