Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: feat(autoware_launch): set use_sim_time parameter equal to true when (#746) #901

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Mar 1, 2024

Description

This reverts commit 2b51045.
cc. @pawellech1

Related PR:

Reason from @maxime-clem :

This change prevents from using use_sim_time:=true outside of using the scenario_simulation.
Previously I would add the argument to my launch command ros2 launch ... use_sim_time:=true but this is no longer possible and I had to revert the changes of this PR.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xmfcx xmfcx self-assigned this Mar 1, 2024
@xmfcx xmfcx added the bug Something isn't working label Mar 1, 2024
@xmfcx xmfcx force-pushed the feat/revert-use-sim-time branch from 794e500 to f8ba0c7 Compare March 1, 2024 09:06
@xmfcx xmfcx force-pushed the feat/revert-use-sim-time branch from f8ba0c7 to 647294e Compare March 1, 2024 09:07
@xmfcx xmfcx changed the title Revert "feat(autoware_launch): set use_sim_time parameter equal to true when … (#746)" revert: feat(autoware_launch): set use_sim_time parameter equal to true when (#746) Mar 1, 2024
@xmfcx xmfcx merged commit 4b09d8c into main Mar 1, 2024
12 of 14 checks passed
@xmfcx xmfcx deleted the feat/revert-use-sim-time branch March 1, 2024 09:11
@xmfcx
Copy link
Contributor Author

xmfcx commented Mar 1, 2024

@takayuki5168 -san, thanks for the quick review!

satoshi-ota pushed a commit to tier4/autoware_launch that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants