Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ndt_scan_matcher): added a parameter of sensor points #908

Conversation

SakodaShintaro
Copy link
Contributor

@SakodaShintaro SakodaShintaro commented Mar 7, 2024

Description

see autowarefoundation/autoware.universe#6559

Tests performed

see autowarefoundation/autoware.universe#6559

Effects on system behavior

see autowarefoundation/autoware.universe#6559

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shintaro SAKODA <[email protected]>
@SakodaShintaro SakodaShintaro changed the title feat(ndt_scan_matcher): added parameters of sensor points feat(ndt_scan_matcher): added a parameter of sensor points Mar 7, 2024
@SakodaShintaro SakodaShintaro marked this pull request as ready for review March 7, 2024 07:00
Signed-off-by: Shintaro SAKODA <[email protected]>
Copy link
Contributor

@TaikiYamada4 TaikiYamada4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SakodaShintaro SakodaShintaro merged commit 7c57ef7 into autowarefoundation:main Mar 12, 2024
9 of 10 checks passed
@SakodaShintaro SakodaShintaro deleted the feat/check_max_distance_of_sensor_points_in_ndt branch March 12, 2024 08:57
4swinv pushed a commit to 4swinv/autoware_launch that referenced this pull request Apr 9, 2024
…oundation#908)

* Added parameters of sensor points

Signed-off-by: Shintaro SAKODA <[email protected]>

* Added unit

Signed-off-by: Shintaro SAKODA <[email protected]>

---------

Signed-off-by: Shintaro SAKODA <[email protected]>
satoshi-ota pushed a commit to tier4/autoware_launch that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants