Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to launch mrm handler #929

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Mar 21, 2024

Description

Add option to use mrm handler. This option is disabled by default.
https://github.com/orgs/autowarefoundation/discussions/4176

Tests performed

This is a sample parameter.

    <arg name="diagnostic_graph_aggregator_param_path" value="$(find-pkg-share diagnostic_graph_aggregator)/config/default.param.yaml"/>
    <arg name="diagnostic_graph_aggregator_graph_path" value="$(find-pkg-share diagnostic_graph_aggregator)/example/graph/main.yaml"/>

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@isamu-takagi isamu-takagi marked this pull request as ready for review March 21, 2024 06:53
@isamu-takagi isamu-takagi requested a review from ito-san as a code owner March 21, 2024 06:53
@isamu-takagi isamu-takagi requested review from mkuri and TetsuKawa March 21, 2024 06:53
Copy link
Contributor

@TetsuKawa TetsuKawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi enabled auto-merge (squash) March 22, 2024 11:52
@isamu-takagi isamu-takagi self-assigned this Mar 27, 2024
Copy link
Contributor

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi merged commit 0694d38 into autowarefoundation:main Mar 28, 2024
10 of 11 checks passed
@isamu-takagi isamu-takagi deleted the feat/launch-mrm-handler-option branch March 28, 2024 03:44
4swinv pushed a commit to 4swinv/autoware_launch that referenced this pull request Apr 9, 2024
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 21, 2024
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 21, 2024
…handler

* feat: add option to launch mrm handler (autowarefoundation#929)

Signed-off-by: Takagi, Isamu <[email protected]>

* chore: add option to select graph path depending on running mode (autowarefoundation#938)

chore: add option of using graph path for simulation

Signed-off-by: Tomohito Ando <[email protected]>

* feat: add a param file of a mrm handler node (autowarefoundation#927)

Signed-off-by: TetsuKawa <[email protected]>

* feat: update config to launch mrm_handler

Signed-off-by: Tomohito Ando <[email protected]>

* feat(mrm_handler): enable comfortable stop

Signed-off-by: Tomohito Ando <[email protected]>

---------

Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Tomohito Ando <[email protected]>
Signed-off-by: TetsuKawa <[email protected]>
Co-authored-by: Takagi, Isamu <[email protected]>
Co-authored-by: TetsuKawa <[email protected]>
Ericpotato pushed a commit to tier4/autoware_launch that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants