Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gnss_launch): remove gnss_frame arg #8

Conversation

KYabuuchi
Copy link
Contributor

@KYabuuchi KYabuuchi commented Jan 19, 2024

Description

I removed gnss_frame arg.

gnns_poser refers to msg.header.frame_id instead of parameter gnss_frame.
Please see autowarefoundation/autoware.universe#6116

(The original reason why we can not pass gnss_frame as arg is autowarefoundation/autoware.universe#5140 )

TIER IV INTERNAL ANNOUNCEMENT LINK

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Kento Yabuuchi <[email protected]>
@KYabuuchi
Copy link
Contributor Author

@mitsudome-r Please review & merge this PR 🙏
(This is not an emergency. The PR just removes unnecessary argument passing.)

@KYabuuchi KYabuuchi requested a review from mitsudome-r January 24, 2024 02:04
@mitsudome-r mitsudome-r merged commit c7c8df3 into autowarefoundation:main Jan 24, 2024
12 of 13 checks passed
@KYabuuchi KYabuuchi deleted the fix/gnss_poser_frame_refers_msg_header branch January 24, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants