forked from tier4/awsim_sensor_kit_launch
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(awsim_labs_sensor_kit_launch): awsim lab load concatenate node parameters #9
Open
vividf
wants to merge
5
commits into
autowarefoundation:main
Choose a base branch
from
vividf:feature/awsim_lab_concatenate
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(awsim_labs_sensor_kit_launch): awsim lab load concatenate node parameters #9
vividf
wants to merge
5
commits into
autowarefoundation:main
from
vividf:feature/awsim_lab_concatenate
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@xmfcx |
vividf
changed the title
feat: awsim lab load concatenate parameter
feat(awsim_labs_sensor_kit_launch): awsim lab load concatenate node parameters
Nov 8, 2024
When
|
vividf
force-pushed
the
feature/awsim_lab_concatenate
branch
from
December 3, 2024 02:53
1ebd714
to
cad0652
Compare
Signed-off-by: vividf <[email protected]>
Signed-off-by: vividf <[email protected]>
Signed-off-by: vividf <[email protected]>
Signed-off-by: vividf <[email protected]>
xmfcx
force-pushed
the
feature/awsim_lab_concatenate
branch
from
December 16, 2024 12:35
a7066c3
to
ef6bd68
Compare
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
introduces a new concatenate algorithm and also removes the default parameter, thus the launcher would need to load the parameter from the parameter file.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.