Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gnss_launch): added autoware_ prefix to gnss_poser #100

Conversation

TaikiYamada4
Copy link
Contributor

@TaikiYamada4 TaikiYamada4 commented Aug 2, 2024

@TaikiYamada4
Copy link
Contributor Author

@knzo25 @drwnz @technolojin
Sorry for interrupting, I chose you as reviewers because you seemed to be involved in sample_sensor_kit recently.
Could someone please review this PR 🙏

Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TaikiYamada4 TaikiYamada4 merged commit f8c256f into autowarefoundation:main Aug 29, 2024
13 of 14 checks passed
@TaikiYamada4 TaikiYamada4 deleted the chore/gnss_poser/add_autoware_prefix branch August 29, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants