Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common_sensor_launch): ring outlier filter load from param file #103

Conversation

vividf
Copy link
Contributor

@vividf vividf commented Aug 29, 2024

Description

PR autowarefoundation/autoware.universe#8468 removes the default parameter, thus common_sensor_launch needs to load the ring outlier parameter from the parameter file.

Related links

Tests performed

ros2 launch autoware_launch logging_simulator.launch.xml map_path:=$HOME/autoware_map/sample-map-rosbag vehicle_model:=sample_vehicle sensor_model:=sample_sensor_kit

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@vividf vividf requested review from YoshiRi and badai-nguyen August 29, 2024 05:16
@vividf
Copy link
Contributor Author

vividf commented Sep 30, 2024

@YoshiRi @badai-nguyen kindly ping

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vividf vividf merged commit a5e7a2d into autowarefoundation:main Oct 1, 2024
8 of 9 checks passed
@xmfcx
Copy link
Contributor

xmfcx commented Oct 2, 2024

@vividf when making changes to this repository, could you also update https://github.com/autowarefoundation/awsim_labs_sensor_kit_launch as well?

We had AWSIM Labs integration broken due to these changes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants