feat: always separate lidar preprocessing from pointcloud_container #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kminoda <[email protected]>
7 tasks
kminoda
changed the title
Signed-off-by: kminoda <[email protected]>
kminoda
force-pushed
the
feat/replace_use_pointcloud_container
branch
from
16b8bed to
eb50925
Compare
Signed-off-by: kminoda <[email protected]>
miursh
reviewed
Jan 17, 2024
miursh
reviewed
Jan 18, 2024
Signed-off-by: kminoda <[email protected]>
7 tasks
|
Hello, firstly thanks for your greate work. I'm wondering why did not you remove |
|
Thank you for your comment. The flag is currently necessary to control whether to attach concatenation node to /pointcloud_container or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See autowarefoundation/autoware.universe#6091
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.