Rename chainID to blockchainID #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-vball
requested review from
michaelkaplan13,
cam-schultz,
minghinmatthewlam,
gwen917 and
bernard-avalabs
as code owners
cam-schultz
reviewed
Nov 22, 2023
Co-authored-by: cam-schultz <[email protected]> Signed-off-by: Geoff Stuart <[email protected]>
Co-authored-by: cam-schultz <[email protected]> Signed-off-by: Geoff Stuart <[email protected]>
bernard-avalabs
previously approved these changes
Nov 24, 2023
cam-schultz
approved these changes
Nov 27, 2023
minghinmatthewlam
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
chainIDusually refers to an ethereum chainID, which is set in the chain genesis. This is distinct fromblockchainID, which uniquely identifies a subnet on Avalanche, and is the hash of the P-Chain tx that creates the blockchain. We have usedchainIDin many places that should beblockchainID, so this PR looks to disambiguate them.Note:
chainIDalways appears as a*big.Intor uint256, whereasblockchainIDis a[32]byte.Closes #95
How this works
How this was tested
How is this documented