Replace stanza package to include concurrent decode bug fix. #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sky333999
approved these changes
Sep 21, 2023
adam-mateen
approved these changes
Sep 21, 2023
ZhenyuTan-amz
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
We made the fix for the concurrent decode bug in
pkg/stanzaas part of amazon-contributing/opentelemetry-collector-contrib#72, but never added a replace directive in our go.mod to include the change in the agent.Description of changes
Adds the replace in the go.mod and added it to the
otel-fork-replace.ymlworkflow.License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Ran an EMF generator with 10 connections/10 threads/~500ms between messages.
v1.300026.3saw corrupted messages after a couple minutes.Built the agent and ran the generator for over an hour. No longer saw corrupted messages.
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint