address more feedback

aws · May 23, 2024 · 5886139 · 5886139
1 parent 0119392
commit 5886139
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/pkg/aws/services/tagging.go b/pkg/aws/services/tagging.go
@@ -144,7 +144,7 @@ func containsTags(source, check Tags) bool {
 			return false
 		}
 	}
-	return true
+	return len(check) != 0
 }
 
 func convertTags(tags []*taggingapi.Tag) Tags {

diff --git a/pkg/aws/services/tagging_test.go b/pkg/aws/services/tagging_test.go
@@ -58,11 +58,11 @@ func TestContainsTags(t *testing.T) {
 				"Key2": aws.String("Value2"),
 			},
 			sourceTags: Tags{
-				"Key1": aws.String("Value1"),
-				"Key2": aws.String("Value2"),
 				"Key3": aws.String("Value3"),
+				"Key2": aws.String("Value2"),
+				"Key1": aws.String("Value1"),
 			},
-			testName: "match subnet of tags from source's multiple tags",
+			testName: "match subset of tags from source's multiple tags",
 		},
 		{
 			contains: false,
@@ -112,6 +112,16 @@ func TestContainsTags(t *testing.T) {
 			sourceTags: Tags{},
 			testName:   "no match for tag when source has no tags",
 		},
+		{
+			contains: false,
+			findTags: Tags{},
+			sourceTags: Tags{
+				"Key1": aws.String("Value1"),
+				"Key2": aws.String("Value2"),
+				"Key3": aws.String("Value3"),
+			},
+			testName: "no match when searching for empty tags",
+		},
 		{
 			contains: false,
 			findTags: Tags{
@@ -158,7 +168,7 @@ func Test_latticeTagging_FindResourcesByTags_nonTargetGroupTypeError(t *testing.
 	nonTargetGroupResourceType := ResourceTypeService
 
 	_, err := lt.FindResourcesByTags(ctx, nonTargetGroupResourceType, Tags{})
-	assert.NotNil(t, err)
+	assert.Error(t, err)
 }
 
 func Test_latticeTagging_FindResourcesByTags_ListTagsError(t *testing.T) {