Create VpcAssociationPolicy e2e test #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zijun726911
force-pushed
the
vap-e2e-test
branch
from
c5f4566 to
a29a4b1
Compare
zijun726911
force-pushed
the
vap-e2e-test
branch
from
a29a4b1 to
a37a9fb
Compare
xWink
reviewed
Oct 3, 2023
| @@ -362,23 +368,23 @@ func (env *Framework) VerifyTargetGroupNotFound(tg *vpclattice.TargetGroupSummar | |||
| }).Should(Succeed()) | |||
| } | |||
|
|
|||
| func (env *Framework) IsVpcAssociatedWithServiceNetwork(ctx context.Context, vpcId string, serviceNetwork *vpclattice.ServiceNetworkSummary) (bool, error) { | |||
| func (env *Framework) IsVpcAssociatedWithServiceNetwork(ctx context.Context, vpcId string, serviceNetwork *vpclattice.ServiceNetworkSummary) (bool, string, error) { | |||
There was a problem hiding this comment.
It's typically considered an antipattern to return multiple values like this. Shouldn't we return a struct type containing named properties, or error?
There was a problem hiding this comment.
If you return association id you can omit bool value. Use empty id as false value.
xWink
approved these changes
Oct 3, 2023
mikhail-aws
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? e2e test cases for the security group api feature #199
What does this PR do / Why do we need it: e2e test cases for the security group api feature #199
If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
Testing done on this change:
Automation added to e2e: Add VpcAssociationPolicy e2e test cases, whole test suite pass
Will this PR introduce any new dependencies?: No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.