-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create VpcAssociationPolicy e2e test #417
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,144 @@ | ||
| package integration | ||
|
|
||
| import ( | ||
| "github.com/aws/aws-sdk-go/aws" | ||
| "github.com/aws/aws-sdk-go/service/ec2" | ||
| "github.com/aws/aws-sdk-go/service/vpclattice" | ||
| . "github.com/onsi/ginkgo/v2" | ||
| . "github.com/onsi/gomega" | ||
| "github.com/samber/lo" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/apimachinery/pkg/types" | ||
| gateway_api_v1alpha2 "sigs.k8s.io/gateway-api/apis/v1alpha2" | ||
| gateway_api "sigs.k8s.io/gateway-api/apis/v1beta1" | ||
|
|
||
| "github.com/aws/aws-application-networking-k8s/pkg/apis/applicationnetworking/v1alpha1" | ||
| "github.com/aws/aws-application-networking-k8s/test/pkg/test" | ||
| ) | ||
|
|
||
| var _ = Describe("Test vpc association policy", Ordered, func() { | ||
| var ( | ||
| vpcAssociationPolicy *v1alpha1.VpcAssociationPolicy | ||
| sgId v1alpha1.SecurityGroupId | ||
| ) | ||
|
|
||
| BeforeAll(func() { | ||
| // Create security group | ||
| describeVpcOutput, err := testFramework.Ec2Client.DescribeVpcs(&ec2.DescribeVpcsInput{ | ||
| VpcIds: []*string{aws.String(test.CurrentClusterVpcId)}, | ||
| }) | ||
| Expect(err).To(BeNil()) | ||
| sourceVPC := describeVpcOutput.Vpcs[0] | ||
| createSgOutput, err := testFramework.Ec2Client.CreateSecurityGroupWithContext(ctx, &ec2.CreateSecurityGroupInput{ | ||
| Description: aws.String("k8s-test-lattice-snva-sg"), | ||
| GroupName: aws.String("k8s-test-lattice-snva-sg"), | ||
| VpcId: aws.String(test.CurrentClusterVpcId), | ||
| }) | ||
| Expect(err).To(BeNil()) | ||
| sgId = v1alpha1.SecurityGroupId(*createSgOutput.GroupId) | ||
|
|
||
| // Create security group inbound rules | ||
| _, err = testFramework.Ec2Client.AuthorizeSecurityGroupIngress(&ec2.AuthorizeSecurityGroupIngressInput{ | ||
| GroupId: createSgOutput.GroupId, | ||
| IpPermissions: []*ec2.IpPermission{ | ||
| { // SG Rule to allow HTTP | ||
| IpProtocol: aws.String("tcp"), | ||
| IpRanges: []*ec2.IpRange{ | ||
| { | ||
| CidrIp: sourceVPC.CidrBlock, | ||
| }, | ||
| }, | ||
| FromPort: aws.Int64(80), | ||
| ToPort: aws.Int64(80), | ||
| }, | ||
| { // SG Rule to allow HTTPS | ||
| IpProtocol: aws.String("tcp"), | ||
| IpRanges: []*ec2.IpRange{ | ||
| { | ||
| CidrIp: sourceVPC.CidrBlock, | ||
| }, | ||
| }, | ||
| FromPort: aws.Int64(443), | ||
| ToPort: aws.Int64(443), | ||
| }, | ||
| }, | ||
| }) | ||
| Expect(err).To(BeNil()) | ||
| }) | ||
|
|
||
| It("Create a VpcAssociationPolicy that set associateWithVpc to false, expecting do not create ServiceNetworkVpcAssociation", func() { | ||
| vpcAssociationPolicy = &v1alpha1.VpcAssociationPolicy{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: "test-vpc-association-policy", | ||
| Namespace: k8snamespace, | ||
| }, | ||
| Spec: v1alpha1.VpcAssociationPolicySpec{ | ||
| TargetRef: &gateway_api_v1alpha2.PolicyTargetReference{ | ||
| Group: gateway_api.GroupName, | ||
| Kind: "Gateway", | ||
| Name: gateway_api_v1alpha2.ObjectName(testGateway.Name), | ||
| Namespace: lo.ToPtr(gateway_api_v1alpha2.Namespace(k8snamespace)), | ||
| }, | ||
| AssociateWithVpc: lo.ToPtr(false), | ||
| }, | ||
| } | ||
| testFramework.ExpectCreated(ctx, vpcAssociationPolicy) | ||
| Eventually(func(g Gomega) { | ||
| //Expect no SNVA for testGateway | ||
| associated, _, err := testFramework.IsVpcAssociatedWithServiceNetwork(ctx, test.CurrentClusterVpcId, testServiceNetwork) | ||
| g.Expect(err).To(Not(BeNil())) | ||
| g.Expect(associated).To(BeFalse()) | ||
| }).Should(Succeed()) | ||
| }) | ||
|
|
||
| It("Update the VpcAssociationPolicy that set associateWithVpc to true with a SecurityGroupId, expecting the ServiceNetworkVpcAssociation with a security group created", func() { | ||
| testFramework.Get(ctx, types.NamespacedName{ | ||
| Namespace: vpcAssociationPolicy.Namespace, | ||
| Name: vpcAssociationPolicy.Name, | ||
| }, vpcAssociationPolicy) | ||
| vpcAssociationPolicy.Spec.AssociateWithVpc = lo.ToPtr(true) | ||
| vpcAssociationPolicy.Spec.SecurityGroupIds = []v1alpha1.SecurityGroupId{sgId} | ||
| testFramework.ExpectUpdated(ctx, vpcAssociationPolicy) | ||
|
|
||
| Eventually(func(g Gomega) { | ||
| associated, snvaId, err := testFramework.IsVpcAssociatedWithServiceNetwork(ctx, test.CurrentClusterVpcId, testServiceNetwork) | ||
| g.Expect(err).To(BeNil()) | ||
| g.Expect(associated).To(BeTrue()) | ||
| output, err := testFramework.LatticeClient.GetServiceNetworkVpcAssociationWithContext(ctx, &vpclattice.GetServiceNetworkVpcAssociationInput{ | ||
| ServiceNetworkVpcAssociationIdentifier: &snvaId, | ||
| }) | ||
| g.Expect(err).To(BeNil()) | ||
| g.Expect(output.SecurityGroupIds).To(HaveLen(1)) | ||
| g.Expect(*output.SecurityGroupIds[0]).To(Equal(string(sgId))) | ||
| }).Should(Succeed()) | ||
| }) | ||
|
|
||
| AfterAll(func() { | ||
| // Re-create SNVA to clean up the SNVA security group by setting associateWithVpc to false and then true with no security group | ||
| vpcAssociationPolicy.Spec.AssociateWithVpc = lo.ToPtr(false) | ||
| vpcAssociationPolicy.Spec.SecurityGroupIds = nil | ||
| testFramework.ExpectUpdated(ctx, vpcAssociationPolicy) | ||
| Eventually(func(g Gomega) { | ||
| //Expect no SNVA for testGateway | ||
| associated, _, _ := testFramework.IsVpcAssociatedWithServiceNetwork(ctx, test.CurrentClusterVpcId, testServiceNetwork) | ||
| g.Expect(associated).To(BeFalse()) | ||
| }).Should(Succeed()) | ||
| vpcAssociationPolicy.Spec.AssociateWithVpc = lo.ToPtr(true) | ||
| testFramework.ExpectUpdated(ctx, vpcAssociationPolicy) | ||
| Eventually(func(g Gomega) { | ||
| // Expect SNVA re-created for testGateway | ||
| associated, _, err := testFramework.IsVpcAssociatedWithServiceNetwork(ctx, test.CurrentClusterVpcId, testServiceNetwork) | ||
| g.Expect(err).To(BeNil()) | ||
| g.Expect(associated).To(BeTrue()) | ||
| }).Should(Succeed()) | ||
|
|
||
| // Clean up the vpc association policy | ||
| testFramework.ExpectDeletedThenNotFound(ctx, vpcAssociationPolicy) | ||
|
|
||
| // Clean up the security group | ||
| _, err := testFramework.Ec2Client.DeleteSecurityGroup(&ec2.DeleteSecurityGroupInput{ | ||
| GroupId: aws.String(string(sgId)), | ||
| }) | ||
| Expect(err).To(BeNil()) | ||
| }) | ||
| }) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's typically considered an antipattern to return multiple values like this. Shouldn't we return a struct type containing named properties, or error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you return association id you can omit bool value. Use empty id as false value.