-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symfony 7 support #102
Comments
Hi @victormacko, thanks for opening this feature request. We will be looking into this soon. Thanks! |
I have checked the return types for Symfony 7, and Aws\Symfony\DependencyInjection\Configuration::getConfigTreeBuilder() has the return type specified. Adding a return type will break backwards compatibility, so this would need to be a major version change (3.x). For Symfony 6, an @return annotation can be added to suppress the deprecation, but this should not be done until a Symfony 7 compatible version is available. |
Hi @rhyd42, we are also planing to deprecate PHP versions below than 7.2.5, so that adding a return type here will be fine, since support for function return type was added after PHP 7. Thanks! |
Hi @victormacko, @rhyd42, we have introduced support for Symfony 7 in the following release. Please reach out if is there anything else we can help with. Thanks! |
|
Describe the feature
Hi there,
Symfony 7 was released recently, and it would be super awesome if this package's composer.json file could also be updated with v7 support.
Thank you for a really great package by the way -- it's very very nice!
Use Case
Symfony 7 is the latest major update to the framework, and without subsequent updates to packages such as this one, it means users of those packages cannot update their software accordingly.
Proposed Solution
Update references to symfony pacakges to include v7 in the composer.json file.
Other Information
No response
Acknowledgements
SDK version used
latest
Environment details (OS name and version, etc.)
OSX, latest
The text was updated successfully, but these errors were encountered: