Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 7 support #102

Closed
2 tasks
victormacko opened this issue Dec 11, 2023 · 5 comments
Closed
2 tasks

Symfony 7 support #102

victormacko opened this issue Dec 11, 2023 · 5 comments
Assignees
Labels
feature-request A feature should be added or improved. needs-review p2 This is a standard priority issue

Comments

@victormacko
Copy link

Describe the feature

Hi there,
Symfony 7 was released recently, and it would be super awesome if this package's composer.json file could also be updated with v7 support.
Thank you for a really great package by the way -- it's very very nice!

Use Case

Symfony 7 is the latest major update to the framework, and without subsequent updates to packages such as this one, it means users of those packages cannot update their software accordingly.

Proposed Solution

Update references to symfony pacakges to include v7 in the composer.json file.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

SDK version used

latest

Environment details (OS name and version, etc.)

OSX, latest

@victormacko victormacko added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 11, 2023
@yenfryherrerafeliz
Copy link
Contributor

Hi @victormacko, thanks for opening this feature request. We will be looking into this soon.

Thanks!

@yenfryherrerafeliz yenfryherrerafeliz self-assigned this Jan 8, 2024
@yenfryherrerafeliz yenfryherrerafeliz added p2 This is a standard priority issue needs-review and removed needs-triage This issue or PR still needs to be triaged. labels Jan 8, 2024
@rhyd42
Copy link

rhyd42 commented Jan 16, 2024

I have checked the return types for Symfony 7, and Aws\Symfony\DependencyInjection\Configuration::getConfigTreeBuilder() has the return type specified. Adding a return type will break backwards compatibility, so this would need to be a major version change (3.x).

For Symfony 6, an @return annotation can be added to suppress the deprecation, but this should not be done until a Symfony 7 compatible version is available.

@yenfryherrerafeliz
Copy link
Contributor

Hi @rhyd42, we are also planing to deprecate PHP versions below than 7.2.5, so that adding a return type here will be fine, since support for function return type was added after PHP 7.

Thanks!

@yenfryherrerafeliz
Copy link
Contributor

Hi @victormacko, @rhyd42, we have introduced support for Symfony 7 in the following release.

Please reach out if is there anything else we can help with.

Thanks!

Copy link

github-actions bot commented Feb 5, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. needs-review p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

3 participants