refactor: improve module structure #203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also improves the documentation of the crate as there are no internal re-exports anymore and everything has a dedicated path. BREAKING CHANGES: - There should now be only a single path to import a specific object. - HttpError is integrated into the Error enum variant
They are exported on top level anyway, so there is no real need for the folders
|
|
Conflicts: examples/api_trait_implementation.rs src/api.rs src/client_reqwest.rs src/client_ureq.rs
while error is nicer, err prevents another line break so its sometimes preferred
the kind already contains this information
@EdJoPaTo sounds good |
Conflicts: src/api.rs src/client_reqwest.rs src/client_ureq.rs src/lib.rs
Conflicts: src/client_reqwest.rs src/client_ureq.rs src/error.rs src/lib.rs src/objects.rs src/parameters.rs src/parse_mode.rs src/response.rs src/trait_async.rs src/trait_sync.rs
|
I think this can be closed soon as all its improvements are slowly added by their own PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also improves the documentation of the crate as there are no internal re-exports anymore and everything has a dedicated path.
BREAKING CHANGES: