test: improve testing for api error response #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the destructuring might mistakenly result in a wrong output. This could be misleading. For example an error code of 500 would result in the panic message while its still an API Error. This moves the assertions to `assert_eq` and only destructures the `Error::Api`
ayrat555
reviewed
Sep 17, 2024
| })) = api.send_message(¶ms) | ||
| { | ||
| assert_eq!("Bad Request: chat not found".to_string(), description); | ||
| if let Err(Error::Api(error)) = dbg!(api.send_message(¶ms)) { |
There was a problem hiding this comment.
do you think dbg should be removed?
There was a problem hiding this comment.
I think its neat to have: when something fails the dbg output will be on the output too which helps to understand the full return value. At first, I thought to only have it on the else case, but it might also be useful when some assert fails.
ayrat555
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the destructuring might mistakenly result in a wrong output. This could be misleading. For example an error code of 500 would result in the panic message while its still an API Error.
This moves the assertions to
assert_eqand only destructures theError::Api