refactor person description messages #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove name & id fields in Face.msg in favor of identity field in Person.msg * remove safe_pose field in Person.msg, so safety logic will be isolated from data model * add comments about legacy field in Person.msg, but not removing for compatibility * remove unused message FaceList.msg * is motivated by discussion in b-it-bots/mas_domestic_robotics#152
argenos
reviewed
Jul 8, 2019
argenos
reviewed
Jul 8, 2019
argenos
approved these changes
Jul 10, 2019
argenos
requested review from
PatrickNa
and removed request for
deebuls and
sthoduka
PatrickNa
approved these changes
Jul 19, 2019
alex-mitrevski
approved these changes
Jul 19, 2019
alex-mitrevski
added a commit
to b-it-bots/mas_domestic_robotics
that referenced
this pull request
Jan 10, 2020
…ew format The person message format was modified with PR b-it-bots/mas_perception_msgs#6
alex-mitrevski
added a commit
to b-it-bots/mas_domestic_robotics
that referenced
this pull request
Jan 10, 2020
…ew format The person message format was modified with PR b-it-bots/mas_perception_msgs#6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Face.msgin favor of identity field inPerson.msgPerson.msg, so safety logic will be isolated from data modelPerson.msg, but not removing for compatibilityFaceList.msgAffected packages
mdr_find_people: this is part of the refactoring, so I think it's fine to remove thesafe_posefieldAdditional comments
After looking through the code in
mcr_people_tracking, andmcr_leg_detection, I think they both need major refactoring and documentation if we plan to use them at all. Whilemcr_leg_detectionseems to be a copy of Willow Garage'sleg_detector,mcr_people_trackingseems worth some further examination.Since I don't plan to spend time on that at the moment, I decided to add comments about this in
Person.msgand keep the legacy fields for compatibility, at least until some other people are willing to spend some time and effort looking into it.