CASTing a DATE literal without time part to TIME datatype fails #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For time datatype PG considers only date value(ex.- '2012-02-23') as bad i/p format. so, above testcase is throwing error from engine code time_in() much before coming to TDS side. However, SQL Server allows casting a date literal string to a TIME datatype when the time component in the string is missing: o/p becomes 00:00:00.0000000 Fix is to add change in time_in() so that it considers date format with missing time info like above one, as valid input when the dialect is TSQL. Task: BABEL-1528 Signed-off-by: Satarupa Biswas [email protected]
bsatarupa
commented
Apr 10, 2023
| * instead of marking it as invalid time format | ||
| */ | ||
| else if (sql_dialect == SQL_DIALECT_TSQL && nf == 1 && ftype[nf - 1] == DTK_DATE) | ||
| return 0; | ||
| /* otherwise, this is a time and/or time zone */ |
There was a problem hiding this comment.
nf = numField (parsed and calculated based on delimiter ' ' and . in any input date)
Ex.
'08-04-1978 13:56:32.125431' has nf count = 3 (08-04-1978, 13:56:32, 125431)
'08-04-1978 13:56:32' has nf count = 2 (08-04-1978, 13:56:32)
'08-04-1978' has nf count = 1 (08-04-1978)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For time datatype PG considers only date value(ex.- '2012-02-23') as bad i/p format. so, above testcase is throwing error from engine code time_in() much before coming to TDS side.
However, SQL Server allows casting a date literal string to a TIME datatype when the time component in the string is missing: o/p becomes 00:00:00.0000000
Fix is to add change in time_in() so that it considers date format with missing time info like above one, as valid input when the dialect is TSQL.
Task: BABEL-1528
Signed-off-by: Satarupa Biswas [email protected]
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.