Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CASTing a DATE literal without time part to TIME datatype fails #125

Open
wants to merge 1 commit into
base: BABEL_3_X_DEV__PG_15_X
Choose a base branch
from
Open

CASTing a DATE literal without time part to TIME datatype fails #125

wants to merge 1 commit into from

Commits on Apr 10, 2023

  1. CASTing a DATE literal without time part to TIME datatype fails 

    For time datatype PG considers only date value(ex.- '2012-02-23') as bad i/p format. so, above testcase is throwing error from engine code time_in() much before coming to TDS side.

However, SQL Server allows casting a date literal string to a TIME datatype when the time component in the string is missing: o/p becomes 00:00:00.0000000

Fix is to add change in time_in() so that it considers date format with missing time info like above one, as valid input when the dialect is TSQL.

Task: BABEL-1528
Signed-off-by: Satarupa Biswas [email protected]
    Satarupa Biswas committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    b8c4ac6 View commit details
    Browse the repository at this point in the history