Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: op e2e test #76

Merged
merged 5 commits into from
Sep 30, 2024
Merged

fix: op e2e test #76

merged 5 commits into from
Sep 30, 2024

Conversation

lesterli
Copy link

@lesterli lesterli commented Sep 29, 2024

Summary

This PR fixes the op e2e tests:

  • only start one consumer FP
    • change the TestOpMultipleFinalityProviders to TestFinalityProviderLifeCycle
  • check if FP exists before start FP to fix the FP already exists

Test Plan

make lint
make test
make test-e2e-op

Copy link
Member

@SebastianElvis SebastianElvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise lgtm. CI seems to be failed though

@lesterli
Copy link
Author

lesterli commented Sep 30, 2024

CI seems to be failed though

Yes, it is weird that all unit tests were passed at my laptop.

Update: unit tests is successful this time.

no op e2e in CI, can we enable it?

@lesterli lesterli merged commit 2382cd3 into base/consumer-chain-support Sep 30, 2024
12 checks passed
@lesterli lesterli deleted the fix/op-e2e-test branch September 30, 2024 03:16
@bap2pecs
Copy link
Contributor

no op e2e in CI, can we enable it?

I checked the logs and it says "file /home/runner/work/finality-provider/finality-provider/itest/opstackl2/devnet-data/allocs-l1.json does not exist"

image

@bap2pecs
Copy link
Contributor

bap2pecs commented Oct 7, 2024

I checked the logs and it says "file /home/runner/work/finality-provider/finality-provider/itest/opstackl2/devnet-data/allocs-l1.json does not exist"

cc @lesterli jfyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants