Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tomo connector #422

Merged
merged 4 commits into from
Dec 3, 2024
Merged

feat: add tomo connector #422

merged 4 commits into from
Dec 3, 2024

Conversation

totraev
Copy link
Contributor

@totraev totraev commented Dec 2, 2024

No description provided.

@totraev totraev force-pushed the feat/integrate-tomo branch from 9ee8070 to 4facf8c Compare December 2, 2024 14:27
Copy link
Contributor

@gbarkhatov gbarkhatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge it since native wallets won't work without this PR, but if we use Tomo OKX and Tomo Keplr
https://i.imgur.com/L8dAXhp.png

@jrwbabylonlab I think you faced this issue before?

fix: a65d6af
rpcRrl -> rpcUrl

@jrwbabylonlab
Copy link
Collaborator

Question: Why not have the tomo inside the wallet connect component?

@totraev
Copy link
Contributor Author

totraev commented Dec 3, 2024

Question: Why not have the tomo inside the wallet connect component?

@jrwbabylonlab I faced several issues while was trying to install Tomo inside bbn-wallet-connect. I spent whole Saturday on it, so I decided to keep it inside simple-staking for now. but I agree that we need move it under bbn-wallet-connect after we resolve all our issues

@jrwbabylonlab
Copy link
Collaborator

Question: Why not have the tomo inside the wallet connect component?

@jrwbabylonlab I faced several issues while was trying to install Tomo inside bbn-wallet-connect. I spent whole Saturday on it, so I decided to keep it inside simple-staking for now. but I agree that we need move it under bbn-wallet-connect after we resolve all our issues

Sounds good.

@totraev
Copy link
Contributor Author

totraev commented Dec 3, 2024

Issues with Tomo inside bbn-wallet-connect:

  1. Buffer is not defined:
Screenshot 2024-12-01 at 09 18 30 Tomo team:

The project requires buffer and process. If you're using Webpack, you can refer to this configuration: https://webpack.js.org/configuration/resolve/#resolvefallback.
You can also check this code for a simple workaround: https://github.com/UnyxTech/tomo-wallet-provider/blob/main/src/demo/Inject.tsx.

  1. Tomo's providers use hardcoded window object to access wallet providers
Screenshot 2024-12-03 at 08 46 06

This would not work inside Storybook cause it runs all components inside iframe.

  1. Tomo's modal does not use react portal what makes it really hard to use inside Storybook

@totraev totraev merged commit 579bd22 into main Dec 3, 2024
1 check passed
@totraev totraev deleted the feat/integrate-tomo branch December 3, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants