Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate staking amount while filling the form #70

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

jrwbabylonlab
Copy link
Collaborator

No description provided.

@jrwbabylonlab jrwbabylonlab force-pushed the proactively-validate-staking-amount branch from 016f298 to e125d02 Compare August 13, 2024 08:26
Copy link
Member

@vitsalis vitsalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some early comments. Will wait for @gbarkhatov and @jeremy-babylonlabs to test first as I'm not well versed in useEffect vs. blur

src/app/components/Staking/Form/StakingAmount.tsx Outdated Show resolved Hide resolved
src/app/components/Staking/Form/StakingAmount.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@gbarkhatov gbarkhatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Achieves the UX given the constraints we have, @jeremy-babylonlabs please also play around

src/app/components/Staking/Staking.tsx Outdated Show resolved Hide resolved
@jrwbabylonlab jrwbabylonlab merged commit 7a94638 into main Aug 14, 2024
1 check passed
@jrwbabylonlab jrwbabylonlab deleted the proactively-validate-staking-amount branch August 14, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants