Drop unused properties from device.json

[vipulgupta2048]

Namely, insturctions, machine and state were properties aren't being used anywhere
in the documentation and hence were removed.

Change-type: patch
Signed-off-by: Vipul Gupta (@vipulgupta2048) [email protected]

---

Please make sure to read the CONTRIBUTING document before opening the PR for relevant information on contributing to the documentation. Thanks!

[vipulgupta2048]

@balena-ci retest

[klutchell]

Aren't we using the device instructions property here?
https://github.com/balena-io/docs/blob/master/shared/getting-started/getDeviceOnDash/_default.md

[vipulgupta2048]

Good find @klutchell I wasn't able to find any instances of device.instructions when I searched for it. You are infact correct, the instructions are getting used here for only those files whose partials are not here: https://github.com/balena-io/docs/tree/master/shared/getting-started/getDeviceOnDash

For example this device, https://www.balena.io/docs/learn/getting-started/nitrogen8mm-dwe/nodejs/#provision-device

[vipulgupta2048]

I can bring back the instructions for devices that don't have partials to avoid duplication of content.

[vipulgupta2048]

@balena-ci rebase

[vipulgupta2048]

Check it out @klutchell

[lurch]

Just out of curiosity I decided to do a bit of "digital archaeology" 😉 and it looks like the community flag was added in #1391 but then obsoleted in #1580

EDIT: I wonder if the arch flag is also now obsolete, as https://github.com/balena-io/docs/blob/master/templates/_devices.html now seems to get that info directly from your API? 🤷

EDIT2: Nope, my mistake, sorry 🤣 It is still used:

$ git grep "\$device\.arch"
shared/getting-started/whatYouNeed/generic-aarch64.md:The {{ $device.name }} image is designed to run in a container on devices with a {{ $device.arch }} architecture.
shared/resinSsh/_default.md:Linux {{ $device.name }}-5dc2c8 3.10.93 #1 SMP PREEMPT Wed Apr 20 10:25:12 CEST 2016 {{ $device.arch }} GNU/Linux

(although of course I have no idea if those pages themselves are also still used!)

[klutchell]

@mehalter I got the impression from our last arch brainstorm that all of this information is migrating to a new device-type source of truth? Will that be a contract type we could leverage here and remove these files?

@vipulgupta2048 This PR looks good to me, we can merge and maybe open a new issue to replace this bit entirely?

[vipulgupta2048]

True that @lurch the arch property is only being used in one place indeed within a balena push out specifically. Would be good to find a solution for that and clean that as well.

@klutchell Indeed in our conversation with @mehalter my plan is to fully wipe out both device.json and language.json dictionaries and have them auto-generated using contracts. I found these properties to be obsolete now and decided to remove them to give us a clear path on knowing what data we have and what we don't have. Good news: We have everything to auto-generate all the properties even instructions.

We can't automate them just yet though because we also need to complete work on screenshots automation for the getting-started guide. With both tasks done + the renovation of getting started guides being done in #2060 we will be in great shape for fully automating the new and improved getting started for the years to come. Check out draft vision: https://docs.google.com/document/d/1oHzkmH_kC6-Z0m7ju5szKDEqE9d_MjhnfY83I2iHgvg/edit#