nginx.conf: Use equal values for client_body_buffer_size and client_m…

[pcarranzav]

…ax_body_size to avoid writing big files to disk

Idea taken from https://medium.com/urban-massage-product/nginx-with-docker-easier-said-than-done-d1b5815d00d0 after noticing a user pushing a big layer
causing out of space errors writing to /var/cache/nginx.

Change-Type: patch
Signed-off-by: Pablo Carranza Velez [email protected]

---

Contributor checklist

• Build output has been rebuilt and tested
• Introduces security considerations
• Tests are included
• Documentation is added or changed
• Affects the development, build or deployment processes of the component

Reviewer Guidelines

• When submitting a review, please pick:
  • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
  • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
  • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

---

[brownjohnf]

Do we want 10m? Is that the default buffer size?

[pcarranzav]

From http://nginx.org/en/docs/http/ngx_http_core_module.html#client_max_body_size looks like default values are 1m and 16k - having a bit larger sounds like a good idea right? But I guess the important part, judging from the Medium post, is that they're the same? rather than the value itself

(playing by ear here)

[brownjohnf]

I'm concerned that if we enlarge the default, we'll consume all available memory if too many users push. We know it currently works, but we don't know exactly what might happen if we enlarge it 10x.

…

On Fri, Dec 8, 2017 at 2:13 PM, Pablo Carranza Vélez < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In nginx.conf <#28 (comment)> : > @@ -43,6 +43,10 @@ http { proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for; # Add to x-forward-for proxy_read_timeout 900; proxy_buffering off; + # These two should be the same or nginx will start writing + # large request bodies to temp files + client_body_buffer_size 10m; From http://nginx.org/en/docs/http/ngx_http_core_module.html# client_max_body_size looks like default values are 1m and 16k - having a bit larger sounds like a good idea right? But I guess the important part, judging from the Medium post, is that they're the same? rather than the value itself (playing by ear here) — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#28 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA9GWV-RRYVx4heuo5F0qZnJrWaJvhHFks5s-bRvgaJpZM4Q7tUK> .

[pcarranzav]

That's a good point. I'll put both in 1m, that is the largest of the two defaults.

[pcarranzav]

Connects-to: https://github.com/resin-io/hq/issues/1115

[dfunckt]

Great find @pcarranzav !

[ghost]

VersionBot failed to commit a new version to prepare a merge for the above pull request here: #28. The reason for this is:
Cloning of branch nginx-client-body-buffer in resin-io/resin-registry2 failed
Please carry out relevant changes or alert an appropriate admin.

[ghost]

@pcarranzav, status checks have failed for this PR. Please make appropriate changes and recommit.

[dfunckt]

I think it should help with #8 as well