Revert "nginx.conf: Use equal values for client_body_buffer_size and client_max_body_size to avoid writing big files to disk" #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…client_max_body_size to avoid writing big files to disk" Revert commit 4159eb5 due to nginx.conf already specifying a client_max_body_size that conflicts with the newly specified one. In fact, client_max_body_size is set to `0`, disabling any limits, therefore preventing the registry from responding with 413 when a client tries to upload large layers. This needs further investigation to determine how Docker behaves with various registry settings, but in the meantime this needs to be reverted. Change-Type: patch Connects-To: #8 HQ: balena-io/balena-io#1115
dfunckt
force-pushed
the
revert-pr-28
branch
from
73bc7b4 to
b5ca550
Compare
pcarranzav
approved these changes
Dec 14, 2017
|
Well, happy as I was that we might have found the cause, I missed it as well :) |
|
I think this confirms that this is the cause though - but it means we can't fix it like this, and probably just need to ensure the server has enough disk space for buffering... right? |
|
Yeah, we probably need to add storage to the registries for temp files. |
|
But I first want to try removing |
dfunckt
added
procbots/versionbot/ready-to-merge
and removed
procbots/versionbot/ready-to-merge
labels
ghost
merged commit 
ghost
removed
the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert commit 4159eb5 due to nginx.conf already specifying a client_max_body_size that conflicts with the newly specified one.
In fact, client_max_body_size is set to
0, disabling any limits, therefore preventing the registry from responding with 413 when a client tries to upload large layers.This needs further investigation to determine how Docker behaves with various registry settings, but in the meantime this needs to be reverted.
Change-Type: patch
Connects-To: #8
See: #28
HQ: https://github.com/resin-io/hq/issues/1115
---- Autogenerated Waffleboard Connection: Connects to #8