Make external functions isolated #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaryamZi
reviewed
Mar 22, 2024
MaryamZi
reviewed
Jun 28, 2024
NipunaMadhushan
force-pushed
the
fix-isolated-methods
branch
from
55dd3d0 to
b0ec6d6
Compare
|
@MaryamZi I have re-added isolated qualifier for public functions. I bumped the minor version as well since this will be a breaking change. |
NipunaMadhushan
force-pushed
the
fix-isolated-methods
branch
from
3b33097 to
b0ec6d6
Compare
TharmiganK
reviewed
Aug 2, 2024
TharmiganK
approved these changes
Aug 2, 2024
MaryamZi
reviewed
Aug 2, 2024
ballerina/natives.bal
Outdated
| } else { | ||
| self.metricTags = DEFAULT_TAGS; | ||
| lock { | ||
| self.metricTags = defaultTags.cloneReadOnly(); |
There was a problem hiding this comment.
Checked and seems like the formatting is correct. Anyway these locks have been removed
MaryamZi
reviewed
Aug 2, 2024
TharmiganK
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
All the external functions should be isolated functions.
Fixes https://github.com/ballerina-platform/module-ballerinax-prometheus/issues/146
Examples
Checklist