Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make external functions isolated #91

Merged
merged 14 commits into from
Aug 2, 2024
Merged

Make external functions isolated #91

Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
430067c
Make external methods isolated
NipunaMadhushan Mar 20, 2024
d0ab92f
Make external methods isolated
NipunaMadhushan Mar 20, 2024
1d6c87f
[Automated] Update the native jar versions
NipunaMadhushan May 9, 2024
e836984
Make public classes isolated
NipunaMadhushan May 9, 2024
c79fd58
Remove extra space
NipunaMadhushan May 9, 2024
4294dbe
Merge branch 'main' into fix-isolated-methods
NipunaMadhushan May 9, 2024
da130c1
Fix uploading codecov report
NipunaMadhushan May 14, 2024
b0ec6d6
Address review suggestions
NipunaMadhushan Jul 4, 2024
c360884
[Automated] Update the native jar versions
NipunaMadhushan Aug 2, 2024
3183557
Update lang version
NipunaMadhushan Aug 2, 2024
68d1fe4
Update distribution version
NipunaMadhushan Aug 2, 2024
b815b06
Update distribution version
NipunaMadhushan Aug 2, 2024
71215d6
Address review suggestions
NipunaMadhushan Aug 2, 2024
0c54a06
Address review suggestions
NipunaMadhushan Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions ballerina/natives.bal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ final map<string> DEFAULT_TAGS = {};
# + spanName - Name of the span
# + tags - Tags to be associated to the span
# + return - SpanId of the started span
public function startRootSpan(string spanName, map<string>? tags = ()) returns int = @java:Method {
public isolated function startRootSpan(string spanName, map<string>? tags = ()) returns int = @java:Method {
NipunaMadhushan marked this conversation as resolved.
Show resolved Hide resolved
'class: "io.ballerina.stdlib.observe.nativeimpl.StartRootSpan",
name: "startRootSpan"
} external;
Expand All @@ -37,7 +37,7 @@ public function startRootSpan(string spanName, map<string>? tags = ()) returns i
# + tags - Tags to be associated to the span
# + parentSpanId - Id of the parent span or -1 if parent span should be taken from system trace
# + return - SpanId of the started span
public function startSpan(string spanName, map<string>? tags = (), int parentSpanId = -1) returns int|error = @java:Method {
public isolated function startSpan(string spanName, map<string>? tags = (), int parentSpanId = -1) returns int|error = @java:Method {
'class: "io.ballerina.stdlib.observe.nativeimpl.StartSpan",
name: "startSpan"
} external;
Expand Down Expand Up @@ -67,7 +67,7 @@ public isolated function addTagToMetrics(string tagKey, string tagValue) returns
#
# + spanId - Id of span to finish
# + return - An error if an error occurred while finishing the span
public function finishSpan(int spanId) returns error? = @java:Method {
public isolated function finishSpan(int spanId) returns error? = @java:Method {
'class: "io.ballerina.stdlib.observe.nativeimpl.FinishSpan",
name: "finishSpan"
} external;
Expand All @@ -83,7 +83,7 @@ public isolated function getSpanContext() returns map<string> = @java:Method {
# Retrieve all registered metrics including default metrics from the ballerina runtime, and user defined metrics.
#
# + return - Array of all registered metrics
public function getAllMetrics() returns Metric[] = @java:Method {
public isolated function getAllMetrics() returns Metric[] = @java:Method {
'class: "io.ballerina.stdlib.observe.nativeimpl.GetAllMetrics",
name: "getAllMetrics"
} external;
Expand All @@ -93,7 +93,7 @@ public function getAllMetrics() returns Metric[] = @java:Method {
# + name - Name of the metric to lookup
# + tags - The key/value pair tags associated with the metric that should be looked up
# + return - The metric instance
public function lookupMetric(string name, map<string>? tags = ()) returns Counter|Gauge? = @java:Method {
public isolated function lookupMetric(string name, map<string>? tags = ()) returns Counter|Gauge? = @java:Method {
'class: "io.ballerina.stdlib.observe.nativeimpl.LookupMetric",
name: "lookupMetric"
} external;
Expand All @@ -103,7 +103,7 @@ public function lookupMetric(string name, map<string>? tags = ()) returns Counte
# + name - Name of the counter metric
# + description - Description of the counter metric
# + metricTags - Tags associated with the counter metric
public class Counter {
public class Counter {
NipunaMadhushan marked this conversation as resolved.
Show resolved Hide resolved

public string name;
public string description;
Expand Down Expand Up @@ -165,32 +165,32 @@ public class Counter {
}
}

function externCounterInit(Counter counter) = @java:Method {
isolated function externCounterInit(Counter counter) = @java:Method {
'class: "io.ballerina.stdlib.observe.nativeimpl.CounterInitialize",
name: "initialize"
} external;

function externCounterRegister(Counter counter) returns error? = @java:Method {
isolated function externCounterRegister(Counter counter) returns error? = @java:Method {
'class: "io.ballerina.stdlib.observe.nativeimpl.CounterRegister",
name: "register"
} external;

function externCounterUnRegister(Counter counter) = @java:Method {
isolated function externCounterUnRegister(Counter counter) = @java:Method {
'class: "io.ballerina.stdlib.observe.nativeimpl.CounterUnregister",
name: "unregister"
} external;

function externCounterIncrement(Counter counter, int amount) = @java:Method {
isolated function externCounterIncrement(Counter counter, int amount) = @java:Method {
'class: "io.ballerina.stdlib.observe.nativeimpl.CounterIncrement",
name: "increment"
} external;

function externCounterReset(Counter counter) = @java:Method {
isolated function externCounterReset(Counter counter) = @java:Method {
'class: "io.ballerina.stdlib.observe.nativeimpl.CounterReset",
name: "reset"
} external;

function externCounterGetValue(Counter counter) returns int = @java:Method {
isolated function externCounterGetValue(Counter counter) returns int = @java:Method {
'class: "io.ballerina.stdlib.observe.nativeimpl.CounterGetValue",
name: "getValue"
} external;
Expand Down Expand Up @@ -282,42 +282,42 @@ public class Gauge {
}
}

function externGaugeInit(Gauge gauge) = @java:Method {
isolated function externGaugeInit(Gauge gauge) = @java:Method {
'class: "io.ballerina.stdlib.observe.nativeimpl.GaugeInitialize",
name: "initialize"
} external;

function externGaugeRegister(Gauge gauge) returns error? = @java:Method {
isolated function externGaugeRegister(Gauge gauge) returns error? = @java:Method {
'class: "io.ballerina.stdlib.observe.nativeimpl.GaugeRegister",
name: "register"
} external;

function externGaugeUnRegister(Gauge gauge) = @java:Method {
isolated function externGaugeUnRegister(Gauge gauge) = @java:Method {
'class: "io.ballerina.stdlib.observe.nativeimpl.GaugeUnregister",
name: "unregister"
} external;

function externGaugeIncrement(Gauge gauge, float amount) = @java:Method {
isolated function externGaugeIncrement(Gauge gauge, float amount) = @java:Method {
'class: "io.ballerina.stdlib.observe.nativeimpl.GaugeIncrement",
name: "increment"
} external;

function externGaugeDecrement(Gauge gauge, float amount) = @java:Method {
isolated function externGaugeDecrement(Gauge gauge, float amount) = @java:Method {
'class: "io.ballerina.stdlib.observe.nativeimpl.GaugeDecrement",
name: "decrement"
} external;

function externGaugeGetValue(Gauge gauge) returns float = @java:Method {
isolated function externGaugeGetValue(Gauge gauge) returns float = @java:Method {
'class: "io.ballerina.stdlib.observe.nativeimpl.GaugeGetValue",
name: "getValue"
} external;

function externGaugeSetValue(Gauge gauge, float amount) = @java:Method {
isolated function externGaugeSetValue(Gauge gauge, float amount) = @java:Method {
'class: "io.ballerina.stdlib.observe.nativeimpl.GaugeSetValue",
name: "setValue"
} external;

function externGaugeGetSnapshot(Gauge gauge) returns Snapshot[]? = @java:Method {
isolated function externGaugeGetSnapshot(Gauge gauge) returns Snapshot[]? = @java:Method {
'class: "io.ballerina.stdlib.observe.nativeimpl.GaugeGetSnapshot",
name: "getSnapshot"
} external;
Expand Down
Loading