Add metrics logs observer #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NipunaMadhushan
requested review from
chathurace and
keizer619
as code owners
| @@ -94,6 +96,15 @@ public static BError enableTracing(BString providerName) { | |||
| } | |||
| } | |||
|
|
|||
| public static BError enableMetricsLogging(Environment env, BString providerName) { | |||
There was a problem hiding this comment.
Return type should be Object
NipunaMadhushan
merged commit 3c54658
into
ballerina-platform:metrics-logs
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We need to implement log based metrics for Ballerina as a requirement for all WSO2 on-prem and SaaS products that need to use the same stack for observability. In order to retrieve metrics data using OpenSearch, we need to provide log based metrics which contain a format as follows.
[Time Stamp] protocol:<protocol_type>, tagKey1:tagValue1, tagKey2:tagValue2, .. | response_time:<value_in_seconds>
We need to add a new Ballerina observer for metrics logs observation.
Fixes ballerina-platform/ballerina-lang#43614
Examples
Checklist