Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics logs observer #120

Merged
merged 12 commits into from
Dec 20, 2024
Merged

Add metrics logs observer #120

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f37ec1d
Add metrics logs observer
NipunaMadhushan Nov 19, 2024
0970764
Add metrics logs observer
NipunaMadhushan Nov 19, 2024
dc1eee0
Move observer classes from ballerina-lang
NipunaMadhushan Nov 21, 2024
8a09df4
Update license headers
NipunaMadhushan Nov 21, 2024
4b31746
Define metric log function name
NipunaMadhushan Nov 21, 2024
3b9b929
Remove metricsLogsProvider config
NipunaMadhushan Nov 22, 2024
0a2ad8d
Fix checkstyle errors
NipunaMadhushan Nov 22, 2024
3fedf01
Remove accessing metrics logs provider
NipunaMadhushan Nov 28, 2024
e7d3ad3
Update lang version
NipunaMadhushan Dec 20, 2024
51eae4e
Merge branch 'metrics-logs' into java21
NipunaMadhushan Dec 20, 2024
12981d1
Skip spotbugsmain
NipunaMadhushan Dec 20, 2024
bd58117
Merge branch 'java21' of https://github.com/NipunaMadhushan/module-ba…
NipunaMadhushan Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ballerina/init.bal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,13 @@ function init() {
externPrintError("failed to enable tracing");
}
}

if (observe:isMetricsLogsEnabled()) {
var err = externEnableMetricsLogging(observe:getMetricsLogsProvider());
if (err is error) {
externPrintError("failed to enable tracing");
}
}
}

function externEnableMetrics(string provider) returns error? = @java:Method {
Expand All @@ -43,6 +50,11 @@ function externEnableTracing(string provider) returns error? = @java:Method {
name: "enableTracing"
} external;

function externEnableMetricsLogging(string provider) returns error? = @java:Method {
'class: "io.ballerina.stdlib.observe.internal.NativeFunctions",
name: "enableMetricsLogging"
} external;

function externPrintError(string message) = @java:Method {
'class: "io.ballerina.stdlib.observe.internal.NativeFunctions",
name: "printError"
Expand Down
11 changes: 11 additions & 0 deletions native/src/main/java/io/ballerina/stdlib/observe/internal/NativeFunctions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,11 @@
*/
package io.ballerina.stdlib.observe.internal;

import io.ballerina.runtime.api.Environment;
import io.ballerina.runtime.api.values.BError;
import io.ballerina.runtime.api.values.BString;
import io.ballerina.runtime.observability.ObserveUtils;
import io.ballerina.runtime.observability.metrics.BallerinaMetricsLogsObserver;
import io.ballerina.runtime.observability.metrics.BallerinaMetricsObserver;
import io.ballerina.runtime.observability.metrics.DefaultMetricRegistry;
import io.ballerina.runtime.observability.metrics.MetricRegistry;
Expand Down Expand Up @@ -94,6 +96,15 @@ public static BError enableTracing(BString providerName) {
}
}

public static BError enableMetricsLogging(Environment env, BString providerName) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return type should be Object

try {
ObserveUtils.addObserver(new BallerinaMetricsLogsObserver(env));
return null;
} catch (BError e) {
return e;
}
}

public static void printError(BString message) {
errStream.println("error: " + message.getValue());
}
Expand Down
Loading