Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add per-target link flags in the right place #2963

Merged
merged 10 commits into from
Oct 26, 2024
Merged

Add per-target link flags in the right place #2963

merged 10 commits into from
Oct 26, 2024

Commits on Oct 26, 2024

  1. Add per-target link flags in the right place 

    Previously we were adding these early on in the link args.

This was a bug - if some transitive dep foo has a linkopt of `-lbar`,
the `-lbar` needs to be later in the link args list than `-lfoo`.

Rather than arbitrarily adding them early on and hoping things work,
this adds the args for each library just after we add a dependency on
that library.
    @illicitonion
    illicitonion committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    0e0d045 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary arg

    @illicitonion
    illicitonion committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    92b6ce8 View commit details
    Browse the repository at this point in the history

  3. Fix up rust deps

    @illicitonion
    illicitonion committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    01840ac View commit details
    Browse the repository at this point in the history

  4. Buildifier

    @illicitonion
    illicitonion committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    4a030a0 View commit details
    Browse the repository at this point in the history

  5. rustfmt

    @illicitonion
    illicitonion committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    7952155 View commit details
    Browse the repository at this point in the history

  6. Fix up some target_compatible_withs

    @illicitonion
    illicitonion committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    c73f7f3 View commit details
    Browse the repository at this point in the history

  7. Ignore another test on Windows

    @illicitonion
    illicitonion committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    aeca70a View commit details
    Browse the repository at this point in the history

  8. Yet more windows

    @illicitonion
    illicitonion committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    739e1d2 View commit details
    Browse the repository at this point in the history

  9. Even more windows

    @illicitonion
    illicitonion committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    e9c37f7 View commit details
    Browse the repository at this point in the history

  10. Hopefully the last windows

    @illicitonion
    illicitonion committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    2ff19be View commit details
    Browse the repository at this point in the history