Incorporation Application UX Updates (#214)

* ux Updates

* removed test code

* removed statment conditions

* Added safet check

* test updates

package.json

@@ -1,6 +1,6 @@
 {
   "name": "business-create-ui",
-  "version": "2.0.2",
+  "version": "2.0.3",
   "private": true,
   "appName": "Create UI",
   "sbcName": "SBC Common Components",

src/components/AddPeopleAndRoles/PeopleAndRoles.vue

@@ -59,8 +59,8 @@
         @click="addOrgPerson([{ roleType: RoleTypes.INCORPORATOR }], IncorporatorTypes.CORPORATION)"
       >
         <v-icon>mdi-domain-plus</v-icon>
-        <span v-if="entityFilter(CorpTypeCd.BENEFIT_COMPANY)">Add a Corporation or Firm</span>
         <span v-if="entityFilter(CorpTypeCd.COOP)">Add Organization</span>
+        <span v-else>Add a Corporation or Firm</span>
       </v-btn>
       <v-btn
         v-if="!hasRole(RoleTypes.COMPLETING_PARTY, 1, 'ATLEAST')"

src/resources/benefitCompany.ts

@@ -6,7 +6,7 @@ import { GetCorpFullDescription } from '@bcrs-shared-components/corp-type-module
 export const BenefitCompanyResource: ResourceIF = {
   entityType: CorpTypeCd.BENEFIT_COMPANY,
   displayName: GetCorpFullDescription(CorpTypeCd.BENEFIT_COMPANY),
-  title: 'Benefit Company Statement',
+  title: 'Benefit Company Statement:',
   description: `This company is a benefit company and, as such, has purposes that include conducting its business
         in a responsible and sustainable manner and promoting one or more public benefits.`,
   statement: null,

src/resources/communityContributionCompany.ts

@@ -6,7 +6,7 @@ import { GetCorpFullDescription } from '@bcrs-shared-components/corp-type-module
 export const CommunityContributionCompanyResource: ResourceIF = {
   entityType: CorpTypeCd.BC_CCC,
   displayName: GetCorpFullDescription(CorpTypeCd.BC_CCC),
-  title: 'Community Contribution Company Statement',
+  title: 'Community Contribution Company Statement:',
   description: `This company is a community contribution company, and, as such, has purposes beneficial to society.
     This company is restricted, in accordance with Part 2.2 of the BCA, in its ability to pay dividends and to
     distribute its assets on dissolution or otherwise.`,

src/resources/cooperative.ts

@@ -5,8 +5,8 @@ import { GetCorpFullDescription } from '@bcrs-shared-components/corp-type-module
 export const CooperativeResource: ResourceIF = {
   entityType: CorpTypeCd.COOP,
   displayName: GetCorpFullDescription(CorpTypeCd.COOP),
-  title: null,
-  description: null,
+  title: 'title placeholder',
+  description: 'descriptor placeholder',
   statement: null,
   nameRequestType: null, // TBD
   steps: [],

src/resources/limitedCompany.ts

@@ -6,7 +6,7 @@ import { GetCorpFullDescription } from '@bcrs-shared-components/corp-type-module
 export const LimitedCompanyResource: ResourceIF = {
   entityType: CorpTypeCd.BC_COMPANY,
   displayName: GetCorpFullDescription(CorpTypeCd.BC_COMPANY),
-  title: 'Limited Company Statement',
+  title: null,
   description: null,
   statement: null,
   nameRequestType: NameRequestTypes.CR,

src/resources/unlimitedCompany.ts

@@ -6,7 +6,7 @@ import { GetCorpFullDescription } from '@bcrs-shared-components/corp-type-module
 export const UnlimitedCompanyResource: ResourceIF = {
   entityType: CorpTypeCd.BC_ULC_COMPANY,
   displayName: GetCorpFullDescription(CorpTypeCd.BC_ULC_COMPANY),
-  title: 'Unlimited Company Statement',
+  title: 'Unlimited Liability Company Statement:',
   description: `The shareholders of this company are jointly and severally liable to satisfy the debts and liabilities
     of this company to the extent provided in section 51.3 of the Business Corporations Act.`,
   statement: null,

src/views/DefineCompany.vue

@@ -1,8 +1,8 @@
 <template>
   <div>
     <div class="mt-10 company-statement">
-      <p>
-        <span class="company-statement-label">{{ getCompanyResources.title }}:</span>
+      <p v-if="getCompanyResources.title">
+        <span class="company-statement-label">{{ getCompanyResources.title }}</span>
         {{ getCompanyResources.description }}
       </p>
     </div>

tests/unit/DefineCompany.spec.ts

@@ -63,7 +63,7 @@ for (const mock of mockEntityInfo) {
       expect(wrapper.find('#folio-number-header').text()).toContain('Folio / Reference Number (optional)')
     })
 
-    it(`displays company statement`, () => {
+    itIf(mock.entityType !== 'BC')(`displays company statement`, () => {
       expect(wrapper.find('.company-statement').exists()).toBe(true)
       expect(wrapper.find('.company-statement p').text()).toContain(mock.description)