feat: Add Legacy Report View #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dhaselhan
commented
Dec 17, 2024
dhaselhan
commented
- Add new brancher to control legacy vs non-legacy view
- Split HistoryCard to its own component for re-usability and add tests
- Update legacy view with legacy assessment card
- Sent legacy_id to the front end
AlexZorkin
requested changes
Dec 18, 2024
frontend/public/config/config.js
Outdated
| @@ -1,5 +1,6 @@ | |||
| export const config = { | |||
| api_base: 'http://localhost:8000/api', | |||
| tfrs_base: 'http://localhost:3001', | |||
There was a problem hiding this comment.
in local we're using port 3000
There was a problem hiding this comment.
I set this to 3001 as LCFS also runs on 3000 so if you were to run both locally at the same time TFRS would need to be on something else. Should I set them to the same?
There was a problem hiding this comment.
I do like the idea but there are quite a few places we would have to update this. vite config, cypress config, application settings, and a few more spots. Maybe leave it as 3000 and then adjust locally when testing this hybrid code. If you want to go through and update it everywhere im not opposed but we would have to test thoroughly.
There was a problem hiding this comment.
Updated to 3000.
dhaselhan
force-pushed
the
feat/daniel-legacy-report-view-1396
branch
2 times, most recently
from
1e52ca9 to
d07e12d
Compare
* Add new brancher to control legacy vs non-legacy view * Split HistoryCard to its own component for re-usability and add tests * Update legacy view with legacy assessment card * Sent legacy_id to the front end
* Rename ComplianceReportViewSelector
dhaselhan
force-pushed
the
feat/daniel-legacy-report-view-1396
branch
from
40c4ab2 to
d10b9fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.