using alamofireimage for transitions when loading thumbnails and graphs #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krugerk
commented
Nov 12, 2024
| self.clearGoalGraph() | ||
| } | ||
| }) | ||
| beeLemniscateView.isHidden = !currentlyShowingGraph |
There was a problem hiding this comment.
It, this MR, does appear to have the consequence of the bee lemniscate not appearing very often.
krugerk
commented
Nov 12, 2024
| }) | ||
| beeLemniscateView.isHidden = !currentlyShowingGraph | ||
|
|
||
| imageView.af.setImage(withURLRequest: request, |
There was a problem hiding this comment.
And here where it is being used in the Today View extension: https://github.com/krugerk/BeeSwift/blob/0456597a73674957ebd7734a7518cf6625f57d25/BeeSwiftToday/TodayTableViewCell.swift#L190
|
I think this changes some current behavior which was intentional. In particular, the intended behavior is:
|
It was already being used in the Today Extension view but not for the graphs and graph thumbnails elsewhere in the app. Using it simplifies the code and allows for easily adding transitions. When scrolling the gallery or loading a goal, the user experience is enhanced by using smooth rather than jarring animations and transitions.
krugerk
force-pushed
the
tweak/alamofireimage-included-but-only-downloader-utilized
branch
from
da7d818 to
336f304
Compare
|
Going to close this out given the above, but comment here if you don't think that's the right action. |
This was referenced Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was already being used in the Today Extension view but not for the graphs and graph thumbnails elsewhere in the app. Using it simplifies the code and allows for easily adding transitions. When scrolling the gallery or loading a goal, the user experience is enhanced by using smooth rather than jarring animations and transitions.