Prevent user import if activation method is not selected #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…username if its empty before create new user. So not nessesary to have checkbox.
juuliabellcom
approved these changes
May 7, 2018
Merged
stankut
reviewed
May 16, 2018
includes/activation_form.inc
Outdated
| @@ -103,8 +103,8 @@ function os2intra_user_import_activate_form_validate($form, &$form_state) { | |||
| } | |||
|
|
|||
| // Check if it matches the users birthday field | |||
| $birthday_field = field_get_items('user', $user, 'field_os2intra_birthdate'); | |||
| if ($input_birthday !== $birthday_field[0]['value']) { | |||
| $birthday_field = field_get_items('user', $user, 'field_os2intra_birthday'); | |||
There was a problem hiding this comment.
@andriyun
odsherred has this field called as field_os2intra_birthday, but fk and faxe have it as field_os2intra_birthdate.
which would mean that after this change it will only work on odsherred.
Is that the desired change?
There was a problem hiding this comment.
i can see we already have a mapping for that field in the settings with they key 'os2intra_user_import_birthday_field', how about using that instead of hardcoding the field?
There was a problem hiding this comment.
Good catch!
I'll fix fix
|
@stanbellcom fixed |
stankut
approved these changes
May 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes related to #12