Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update delete-unused-users.py #5076

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

moschlar
Copy link
Contributor

Fix logic error in to_delete selection

😉

Fix logic error in to_delete selection

:wink:
@shaneknapp
Copy link
Contributor

thanks for the fix... and this script definitely needs a refactor regardless.

i'm also curious how you stumpbled across this repo and script... :)

@shaneknapp shaneknapp merged commit d724316 into berkeley-dsep-infra:staging Sep 27, 2023
@moschlar
Copy link
Contributor Author

@shaneknapp I searched for "JupyterHub delete inactive user" or something like that and stumbled upon your documentation page at https://docs.datahub.berkeley.edu/en/latest/admins/howto/remove-users-orm.html 😉

And if I were more familiar with async Python programming, I would have prepared a PR fixing the pagination issue - but my current hacky solution in jhub_client isn't really appropriate...

@shaneknapp
Copy link
Contributor

@shaneknapp I searched for "JupyterHub delete inactive user" or something like that and stumbled upon your documentation page at https://docs.datahub.berkeley.edu/en/latest/admins/howto/remove-users-orm.html 😉

And if I were more familiar with async Python programming, I would have prepared a PR fixing the pagination issue - but my current hacky solution in jhub_client isn't really appropriate...

hah! we are indeed the first result... :)

async can be tricky, that's for sure. since i inherited this script, i wanted to make it a little more human-parseable before trying to fix the pagination bug.

another way to do this can be found here: https://discourse.jupyter.org/t/is-there-a-way-to-bulk-delete-old-users/20866/3

moschlar added a commit to moschlar/datahub that referenced this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants