Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DH-145] fix pagination, basically a complete rewrite #5093

Merged
merged 7 commits into from
Oct 4, 2023
Merged

[DH-145] fix pagination, basically a complete rewrite #5093

merged 7 commits into from
Oct 4, 2023

Conversation

shaneknapp
Copy link
Contributor

No description provided.

ryanlovett
ryanlovett approved these changes Sep 30, 2023
View reviewed changes
Copy link
Collaborator

@ryanlovett ryanlovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I haven't run it. :)

scripts/delete-unused-users.py Outdated Show resolved Hide resolved
scripts/delete-unused-users.py Outdated Show resolved Hide resolved
@shaneknapp
Copy link
Contributor Author

Looks good, but I haven't run it. :)

usernames redacted, but here's a sample run from the a11y hub:

(dh) ➜  scripts git:(fix-pagination-bug) ✗ ./delete-unused-users.py --hub_url https://a11y.datahub.berkeley.edu/
1: deleting XXXX
2: deleting XXXX
3: deleting XXXX
4: deleting XXXX
5: deleting XXXX
6: deleting XXXX
7: deleting XXXX
8: deleting XXXX
9: deleting XXXX
Deleted 9 total users.

--debug and --verbose also work as expected :)

@shaneknapp shaneknapp mentioned this pull request Oct 4, 2023
Closed
@github-actions github-actions bot added the documentation Issues around adding and modifying docs label Oct 4, 2023
@shaneknapp shaneknapp merged commit 8220cb1 into berkeley-dsep-infra:staging Oct 4, 2023
2 checks passed
@shaneknapp shaneknapp deleted the fix-pagination-bug branch October 4, 2023 22:05
@moschlar moschlar mentioned this pull request Oct 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanlovett ryanlovett ryanlovett approved these changes

Assignees
No one assigned
Labels
documentation Issues around adding and modifying docs python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaneknapp @ryanlovett