Fix cloning entities with multiple linked_spawn
relationships
#17726
+49
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
#17687 changed recursive cloning to queue cloning commands for entities in
linked_spawn
RelationshipTarget
s. However, if there are multiple relationships withlinked_spawn
on the same entity, multiple clone commands will be queued for the same entity.Solution
Maintain a list of already cloned entities during one
clone_entity_mapped
call and skip as necessary.Testing
linked_spawn
relations.