Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make bevy math publishable #17727

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Feb 7, 2025

Objective

  • bevy_math fails to publish because of the self dev-dependency
  • it's used to enable the approx feature in tests

Solution

  • Don't specify a version in the dev-dependency. dependencies without a version are ignored by cargo when publishing
  • Gate all the tests that depend on the approx feature so that it doesn't fail to compile when not enabled
  • Also gate an import that wasn't used without bevy_reflect

Testing

  • with at least cargo 1.84: cargo package -p bevy_math
  • cd target/package/bevy_math_* && cargo test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants