Add http
& https
asset sources (clean commit history)
#17889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
This is a duplicate of #16366 because I made a mess of the commit history. See that pr for more context and discussion.
bevy_web_asset
, allowing assets loaded viahttp
#16307http
&https
asset sources #16366Licencing
this pr adds two licences:
ci still picks up ring because
examples/remote/client.rs
is still using default-features. Perhaps in another pr we can expose a generalfetch
function with theaws-lc-rs
machinery used in this pr.Solution
http
&https
asset sourcesTesting
cargo run --example http_source
Showcase
Bevy now supports assets loaded via url!
Add the
http_source
feature to load assets served over the web, with support for both native and wasm targets. On native targets thehttp_source_cache
feature will use a basic caching mechanism to avoid repeated network requests.Further Work
aws-lc-rs
because it has a cleaner license than ring but apparently it requirescmake
installed on windows so may be less ergonomic.