Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NonMesh draw command item queries #17893

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brianreavis
Copy link
Contributor

@brianreavis brianreavis commented Feb 17, 2025

This fixes NonMesh draw commands not receiving render-world entities since

This unbreaks item queries for queued non-mesh entities:

struct MyDrawCommand {
    type ItemQuery = Read<DynamicUniformIndex<SomeUniform>>;
    // ...
}

Solution

Pass render entity to NonMesh draw commands instead of Entity::PLACEHOLDER. This PR also introduces sorting of the NonMesh bin keys like other types, which I assume is the intended behavior. @pcwalton

Testing

  • Tested on a local project that extensively uses NonMesh items.

…nd sort by key like other phase items

Unbreaks draw command item queries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant