Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node::transform field #17919

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions crates/bevy_ui/src/layout/convert.rs
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,8 @@ impl RepeatedGridTrack {

#[cfg(test)]
mod tests {
use bevy_transform::components::Transform;

use super::*;

#[test]
Expand Down Expand Up @@ -522,6 +524,7 @@ mod tests {
],
grid_column: GridPlacement::start(4),
grid_row: GridPlacement::span(3),
transform: Transform::IDENTITY,
};
let viewport_values = LayoutContext::new(1.0, bevy_math::Vec2::new(800., 600.));
let taffy_style = from_node(&node, &viewport_values, false);
Expand Down
5 changes: 2 additions & 3 deletions crates/bevy_ui/src/layout/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -288,9 +288,8 @@ with UI components as a child of an entity without UI components, your UI layout
.max(0.);
}

if transform.translation.truncate() != node_center {
transform.translation = node_center.extend(0.);
}
transform
.set_if_neq(style.transform * Transform::from_translation(node_center.extend(0.)));

let scroll_position: Vec2 = maybe_scroll_position
.map(|scroll_pos| {
Expand Down
6 changes: 4 additions & 2 deletions crates/bevy_ui/src/ui_node.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ use bevy_reflect::prelude::*;
use bevy_render::{
camera::{Camera, RenderTarget},
view::Visibility,
view::VisibilityClass,
};
use bevy_sprite::BorderRect;
use bevy_transform::components::Transform;
Expand Down Expand Up @@ -331,7 +330,6 @@ impl From<Vec2> for ScrollPosition {
ScrollPosition,
Transform,
Visibility,
VisibilityClass,
ZIndex
)]
#[reflect(Component, Default, PartialEq, Debug)]
Expand Down Expand Up @@ -620,6 +618,9 @@ pub struct Node {
///
/// <https://developer.mozilla.org/en-US/docs/Web/CSS/grid-column>
pub grid_column: GridPlacement,

/// Rotate, scale, skew, or translate the node and its content.
pub transform: Transform,
}

impl Node {
Expand Down Expand Up @@ -663,6 +664,7 @@ impl Node {
grid_auto_columns: Vec::new(),
grid_column: GridPlacement::DEFAULT,
grid_row: GridPlacement::DEFAULT,
transform: Transform::IDENTITY,
};
}

Expand Down
34 changes: 12 additions & 22 deletions examples/ui/overflow_debug.rs
Original file line number Diff line number Diff line change
Expand Up @@ -41,35 +41,35 @@ struct AnimationState {
struct Container(u8);

trait UpdateTransform {
fn update(&self, t: f32, transform: &mut Transform);
fn update(&self, t: f32, transform: &mut Node);
}

#[derive(Component)]
struct Move;

impl UpdateTransform for Move {
fn update(&self, t: f32, transform: &mut Transform) {
transform.translation.x = ops::sin(t * TAU - FRAC_PI_2) * HALF_CONTAINER_SIZE;
transform.translation.y = -ops::cos(t * TAU - FRAC_PI_2) * HALF_CONTAINER_SIZE;
fn update(&self, t: f32, node: &mut Node) {
node.transform.translation.x = ops::sin(t * TAU - FRAC_PI_2) * HALF_CONTAINER_SIZE;
node.transform.translation.y = -ops::cos(t * TAU - FRAC_PI_2) * HALF_CONTAINER_SIZE;
}
}

#[derive(Component)]
struct Scale;

impl UpdateTransform for Scale {
fn update(&self, t: f32, transform: &mut Transform) {
transform.scale.x = 1.0 + 0.5 * ops::cos(t * TAU).max(0.0);
transform.scale.y = 1.0 + 0.5 * ops::cos(t * TAU + PI).max(0.0);
fn update(&self, t: f32, node: &mut Node) {
node.transform.scale.x = 1.0 + 0.5 * ops::cos(t * TAU).max(0.0);
node.transform.scale.y = 1.0 + 0.5 * ops::cos(t * TAU + PI).max(0.0);
}
}

#[derive(Component)]
struct Rotate;

impl UpdateTransform for Rotate {
fn update(&self, t: f32, transform: &mut Transform) {
transform.rotation =
fn update(&self, t: f32, node: &mut Node) {
node.transform.rotation =
Quat::from_axis_angle(Vec3::Z, (ops::cos(t * TAU) * 45.0).to_radians());
}
}
Expand Down Expand Up @@ -175,10 +175,6 @@ fn spawn_container(
update_transform: impl UpdateTransform + Component,
spawn_children: impl FnOnce(&mut ChildSpawnerCommands),
) {
let mut transform = Transform::default();

update_transform.update(0.0, &mut transform);

parent
.spawn((
Node {
Expand All @@ -198,11 +194,8 @@ fn spawn_container(
Node {
align_items: AlignItems::Center,
justify_content: JustifyContent::Center,
top: Val::Px(transform.translation.x),
left: Val::Px(transform.translation.y),
..default()
},
transform,
update_transform,
))
.with_children(spawn_children);
Expand Down Expand Up @@ -233,13 +226,10 @@ fn update_animation(

fn update_transform<T: UpdateTransform + Component>(
animation: Res<AnimationState>,
mut containers: Query<(&mut Transform, &mut Node, &ComputedNode, &T)>,
mut containers: Query<(&mut Node, &T)>,
) {
for (mut transform, mut node, computed_node, update_transform) in &mut containers {
update_transform.update(animation.t, &mut transform);

node.left = Val::Px(transform.translation.x * computed_node.inverse_scale_factor());
node.top = Val::Px(transform.translation.y * computed_node.inverse_scale_factor());
for (mut node, update_transform) in &mut containers {
update_transform.update(animation.t, &mut node);
}
}

Expand Down